Skip to content

Cleanup development feature flags for locking namespaces fix

What does this MR do and why?

Cleanup feature flags sync_traversal_ids_before_commit, for_no_key_update_lock related to fixing the namespace locking issues.

I've taken the path of moving from FFs default off to removing the FF based on documentation https://docs.gitlab.com/ee/development/feature_flags/index.html#changelog

NOTE: the for_no_key_update_lock FF was enabled on staging and production on 25th Feb.

Logs since 2022-02-21

Note that we expect to see some locking timeouts, we cannot completely exclude those as it depends on the duration the lock is held and the number of concurrent traversal_ids being updated for same hierarchy. However the number of locks timeouts we are seeing is a very low percentage.

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Alexandru Croitor

Merge request reports

Loading