Skip to content

Adapt find page method to accept new skip_content RPC param

Francisco Javier López (ex-Gitlab) requested to merge 336792-fj-update-find-page-params-to-use-load-content into master

What does this MR do and why?

In gitaly!4373 (merged), we added a new param called skip_content to the RPC WikiFindPage. This param allows us to avoid loading the content of the wiki page whenever is not needed.

In this MR, we're introducing that new param to the methods chain that uses it. To avoid breaking the functionality and avoid making a lot of changes, we're going to make it false by default. The reason we're using load_content in all these methods instead of the newly added param to the RPC skip_content, it's because we already have other methods that use other RPCs, with the same param name, so it's basically for consistency.

How to set up and validate locally

  1. Inside a project with a wiki and with a home wiki page do: project.wiki.find_page('home', load_content: true).raw_data and project.wiki.find_page('home', load_content: false).raw_data

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #336792 (closed)

Edited by Francisco Javier López (ex-Gitlab)

Merge request reports