Fix usage of distance_of_time_in_words_to_now
What does this MR do and why?
This MR aims to solve the issue #341248 (closed)
File Change
app/views/admin/system_info/show.html.haml
Page
Admin Area > Info System
Relative Time | ![]() |
Absolute Time | ![]() |
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
Thank you for your contribution to GitLab. We believe that everyone can contribute and contributions like yours are what make GitLab great!
- Our Merge Request Coaches will ensure your contribution is reviewed in a timely manner*.
- If you haven't, please set up a
DANGER_GITLAB_API_TOKEN
. - You can comment
@gitlab-bot label ~"group::"
to add a group label. - When you feel your MR (merge request) is ready for a review, just ask
@gitlab-bot request_review
and someone will take a look. - If you are stuck, feel free to ask
@gitlab-bot help
or ping a Merge Request Coach. - Read more on how to get help.
This message was generated automatically. You're welcome to improve it.
added Community contribution label
assigned to @edith007
added Hackathon label
4 Warnings This merge request contains deprecated components. Please consider using Pajamas components instead. You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the ~"type::tooling", ~"tooling::pipelines", ~"tooling::workflow", documentation, QA labels.Please add a merge request type to this merge request. This merge request does not refer to an existing milestone. Deprecated components
These deprecated components are in the process of being migrated. Please consider using Pajamas components instead.
- with_tooltip
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Tristan Read ( @tristan.read
) (UTC+13)Vitaly Slobodin ( @vitallium
) (UTC+3)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangermentioned in issue gitlab-org/quality/triage-reports#6499 (closed)
changed milestone to %14.8
removed milestone %14.8
removed [deprecated] Accepting merge requests label
@tristan.read Could you please review? Thanks!
requested review from @tristan.read
- Resolved by Reuben Pereira
@edith007 I tested out the UI locally, there's an issue - the wording has changed and no longer matches the header:
before after Is there an option for this method (or an alternative rails method), that fixes the issue without changing the wording? If not, then a pragmatic solution might be to update the header to 'Booted' or something similar.
Back to you to investigate. Let me know if you'd like a second pair of eyes digging into the codebase for an alternative
Edited by Tristan Read
removed review request for @tristan.read
added idle label
mentioned in issue gitlab-org/quality/triage-reports#7080 (closed)
removed idle label
added 6472 commits
-
bcc8484f...898599bd - 6471 commits from branch
gitlab-org:master
- 7da500e7 - Fix usage of distance_of_time_in_words_to_now
-
bcc8484f...898599bd - 6471 commits from branch
2 Warnings This merge request contains deprecated components. Please consider using Pajamas components instead. This merge request does not refer to an existing milestone. Deprecated components
These deprecated components are in the process of being migrated. Please consider using Pajamas components instead.
- with_tooltip
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Qingyu Zhao ( @qzhaogitlab
) (UTC+10)Heinrich Lee Yu ( @engwan
) (UTC+8)frontend Eduardo Sanz-Garcia ( @eduardosanz
) (UTC+2)Ezekiel Kigbo ( @ekigbo
) (UTC+10)test for spec/features/*
Andrejs Cunskis ( @acunskis
) (UTC+0)Maintainer review is optional for test for spec/features/*
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Siddharth Asthanaadded idle label
mentioned in issue gitlab-org/quality/triage-reports#7598 (closed)
mentioned in issue gitlab-org/quality/triage-reports#7690 (closed)
added workflowin dev label and removed workflowproduction label
added 12278 commits
-
7da500e7...5ad85764 - 12277 commits from branch
gitlab-org:master
- 1abfeeb0 - Fix usage of distance_of_time_in_words_to_now
-
7da500e7...5ad85764 - 12277 commits from branch
removed idle label
added workflowready for review label and removed workflowin dev label
requested review from @rpereira2 and @tristan.read
@rpereira2 @tristan.read, this Community contribution is ready for review.
- Do you have capacity and domain expertise to review this? We are mindful of your time, so if you are not able to take this on, please re-assign to one or more other reviewers.
- Add the workflowin dev label if the merge request needs action from the author.
requested review from @dmoraBerlin
- Resolved by Reuben Pereira
added 927 commits
-
1abfeeb0...3b48b7a8 - 926 commits from branch
gitlab-org:master
- db5062f8 - Fix usage of distance_of_time_in_words_to_now
-
1abfeeb0...3b48b7a8 - 926 commits from branch
added 21 commits
-
db5062f8...59a796ba - 20 commits from branch
gitlab-org:master
- 0c6a77af - Fix usage of distance_of_time_in_words_to_now
-
db5062f8...59a796ba - 20 commits from branch
added 5 commits
-
0c6a77af...80f675b3 - 4 commits from branch
gitlab-org:master
- abf386c2 - Fix usage of distance_of_time_in_words_to_now
-
0c6a77af...80f675b3 - 4 commits from branch
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @dbalexandre
,@mayra-cabrera
,@marin
,@dzaporozhets
,@tkuah
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
1 Warning This merge request contains deprecated components. Please consider using Pajamas components instead. Deprecated components
These deprecated components are in the process of being migrated. Please consider using Pajamas components instead.
- with_tooltip
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Mehmet Emin Inac ( @minac
) (UTC+3)Peter Leitzen ( @splattael
) (UTC+2)frontend André Luís ( @andr3
) (UTC+1)Jannik Lehmann ( @jannik_lehmann
) (UTC+2)test for spec/features/*
Andrejs Cunskis ( @acunskis
) (UTC+3)Maintainer review is optional for test for spec/features/*
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangerchanged milestone to %15.2
- Resolved by Ezekiel Kigbo
@rpereira2
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, please start a new pipeline before merging.
For more info, please refer to the following links:
- Resolved by Ezekiel Kigbo
Thanks @edith007, backend LGTM!
@tristan.read Would you mind assigning to a frontend maintainer if this looks good? I don't think this needs a backend maintainer review.
Allure report
allure-report-publisher
generated test report!review-qa-blocking:
test report for c4a8c391expand test summary
+-----------------------------------------------------------------------------------------+ | suites summary | +------------------------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Verify | 12 | 0 | 1 | 12 | 13 | ❗ | | Plan | 47 | 0 | 1 | 47 | 48 | ❗ | | Create | 23 | 0 | 2 | 23 | 25 | ❗ | | Protect | 2 | 0 | 0 | 2 | 2 | ❗ | | Manage | 38 | 0 | 2 | 40 | 40 | ❗ | | Configure | 0 | 0 | 1 | 0 | 1 | ➖ | | Secure | 2 | 0 | 0 | 2 | 2 | ❗ | | Feature flag handler sanity checks | 9 | 0 | 0 | 9 | 9 | ❗ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Version sanity check | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Total | 133 | 0 | 9 | 135 | 142 | ❗ | +------------------------------------+--------+--------+---------+-------+-------+--------+
removed review request for @tristan.read
requested review from @ekigbo
added workflowin review label and removed workflowready for review label
enabled an automatic merge when the pipeline for 6e0575a2 succeeds
added 663 commits
-
abf386c2...ab829bc3 - 662 commits from branch
gitlab-org:master
- c4a8c391 - Fix usage of distance_of_time_in_words_to_now
-
abf386c2...ab829bc3 - 662 commits from branch
enabled an automatic merge when the pipeline for dc3ff54a succeeds
@edith007, how was your code review experience with this merge request? Please tell us how we can continue to iterate and improve:
- Leave a
or a on this comment to describe your experience. - Create a new comment starting with
@gitlab-bot feedback
below, and leave any additional feedback you have for us in the comment.
Have five minutes? Take our survey to give us even more feedback on how GitLab can improve the contributor experience.
Thanks for your help!
This message was generated automatically. You're welcome to improve it.
- Leave a
mentioned in commit b704061b
added workflowstaging-canary label and removed workflowin review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
mentioned in merge request !92635 (merged)
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!1252 (merged)