Skip to content
Snippets Groups Projects

Fix usage of distance_of_time_in_words_to_now

Merged Siddharth Asthana requested to merge edith007/gitlab:issue_341248_show.html.haml into master
All threads resolved!

What does this MR do and why?

This MR aims to solve the issue #341248 (closed)

File Change

  • app/views/admin/system_info/show.html.haml

Page

Admin Area > Info System

Relative Time image
Absolute Time image

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Siddharth Asthana

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Siddharth Asthana added 927 commits

    added 927 commits

    Compare with previous version

  • Siddharth Asthana added 21 commits

    added 21 commits

    Compare with previous version

  • Siddharth Asthana changed the description

    changed the description

  • added 5 commits

    Compare with previous version

  • Suggested Reviewers (beta)

    The individuals below may be good candidates to participate in the review based on various factors.

    You can use slash commands in comments to quickly assign /assign_reviewer @user1.

    Suggested Reviewers
    @dbalexandre, @mayra-cabrera, @marin, @dzaporozhets, @tkuah

    If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue: https://gitlab.com/gitlab-org/gitlab/-/issues/357923.

    Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".

  • 1 Warning
    :warning: This merge request contains deprecated components. Please consider using Pajamas components instead.

    Deprecated components

    These deprecated components are in the process of being migrated. Please consider using Pajamas components instead.

    • with_tooltip

    Reviewer roulette

    Changes that require review have been detected!

    Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

    Category Reviewer Maintainer
    backend Mehmet Emin Inac (@minac) (UTC+3) Peter Leitzen (@splattael) (UTC+2)
    frontend André Luís (@andr3) (UTC+1) Jannik Lehmann (@jannik_lehmann) (UTC+2)
    test for spec/features/* Andrejs Cunskis (@acunskis) (UTC+3) Maintainer review is optional for test for spec/features/*

    To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

    Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

  • Reuben Pereira changed milestone to %15.2

    changed milestone to %15.2

  • Reuben Pereira approved this merge request

    approved this merge request

  • Allure report

    allure-report-publisher generated test report!

    review-qa-blocking: :exclamation: test report for c4a8c391

    expand test summary
    +-----------------------------------------------------------------------------------------+
    |                                     suites summary                                      |
    +------------------------------------+--------+--------+---------+-------+-------+--------+
    |                                    | passed | failed | skipped | flaky | total | result |
    +------------------------------------+--------+--------+---------+-------+-------+--------+
    | Verify                             | 12     | 0      | 1       | 12    | 13    | ❗     |
    | Plan                               | 47     | 0      | 1       | 47    | 48    | ❗     |
    | Create                             | 23     | 0      | 2       | 23    | 25    | ❗     |
    | Protect                            | 2      | 0      | 0       | 2     | 2     | ❗     |
    | Manage                             | 38     | 0      | 2       | 40    | 40    | ❗     |
    | Configure                          | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Secure                             | 2      | 0      | 0       | 2     | 2     | ❗     |
    | Feature flag handler sanity checks | 9      | 0      | 0       | 9     | 9     | ❗     |
    | Package                            | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Version sanity check               | 0      | 0      | 1       | 0     | 1     | ➖     |
    +------------------------------------+--------+--------+---------+-------+-------+--------+
    | Total                              | 133    | 0      | 9       | 135   | 142   | ❗     |
    +------------------------------------+--------+--------+---------+-------+-------+--------+
  • Tristan Read approved this merge request

    approved this merge request

  • Tristan Read removed review request for @tristan.read

    removed review request for @tristan.read

  • Tristan Read requested review from @ekigbo

    requested review from @ekigbo

  • Ezekiel Kigbo approved this merge request

    approved this merge request

  • Ezekiel Kigbo resolved all threads

    resolved all threads

  • Ezekiel Kigbo enabled an automatic merge when the pipeline for 6e0575a2 succeeds

    enabled an automatic merge when the pipeline for 6e0575a2 succeeds

  • Rebasing, then i'll reset MWPS which should fix the pipeline.

  • Ezekiel Kigbo added 663 commits

    added 663 commits

    Compare with previous version

  • Ezekiel Kigbo enabled an automatic merge when the pipeline for dc3ff54a succeeds

    enabled an automatic merge when the pipeline for dc3ff54a succeeds

  • merged

  • @edith007, how was your code review experience with this merge request? Please tell us how we can continue to iterate and improve:

    1. Leave a :thumbsup: or a :thumbsdown: on this comment to describe your experience.
    2. Create a new comment starting with @gitlab-bot feedback below, and leave any additional feedback you have for us in the comment.

    Have five minutes? Take our survey to give us even more feedback on how GitLab can improve the contributor experience.

    Thanks for your help! :heart:

    This message was generated automatically. You're welcome to improve it.

  • Ezekiel Kigbo mentioned in commit b704061b

    mentioned in commit b704061b

  • added workflowstaging label and removed workflowcanary label

  • Evan Read mentioned in merge request !92635 (merged)

    mentioned in merge request !92635 (merged)

  • Please register or sign in to reply
    Loading