Replace window.confirm in deprecated_modal
What does this MR do and why?
This MR replaces the calls to window.confirm in app/assets/javascripts/deprecated_notes.js with the implementation using GlModal as part of &6993 (closed).
Screenshots or screen recordings
| before | with this MR |
|---|---|
| Screen_Recording_2022-02-18_at_13.37.24 | Screen_Recording_2022-02-18_at_13.22.29 |
How to set up and validate locally
For the first modal:
- comment on a commit diff
- edit the text of your comment
- press the Escape key while editing to cancel
-
Are you sure you want to discard this comment?modal should appear
For the second modal:
- ??? (I still haven't figured out where this modal appears
😅 ) -
Your comment will be discarded.modal should appear
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #344122 (closed)
Edited by Miranda Fluharty