Skip to content

Update group runner links

Miguel Rincon requested to merge 336405-runner-list-group-links into master

What does this MR do and why?

This change ensures that when the new runner list feature is enabled:

  • breadcrumbs link lead to it
  • menu items are active in runner pages

This MR helps prepare for rollout of #350164 (closed)

Screenshots or screen recordings

When the runner_list_group_view_vue_ui feature flag is enabled, links are updated as below. When the FF is off no changes are expected.

Group -> View Runner

Screen_Shot_2022-02-18_at_4.32.35_PM

Group -> Edit Runner

Screen_Shot_2022-02-18_at_4.33.08_PM

Project -> Runners -> Group Runners

This is a project which has no group runners attached.

Screen_Shot_2022-02-18_at_4.39.56_PM

How to set up and validate locally

  1. Enable feature flag runner_list_group_view_vue_ui (rollout #336405 (closed)) with some runners registered to a group and logged in as a group owner admin
  2. Visit the Group -> Runners e.g. http://gdk.test:3000/groups/h5bp/-/runners
  3. Click on a runner http://gdk.test:3000/groups/h5bp/-/runners/77
  4. Visit http://gdk.test:3000/groups/h5bp/-/runners/77/edit (link is added at !80924 (merged))

#336405 (closed)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #336405 (closed)

Edited by Miguel Rincon

Merge request reports