Skip to content

Remove new environments table feature flag

Andrew Fontaine requested to merge afontaine/update-rspec-environments into master

What does this MR do and why?

Fetch specific scope for environment folder

If the user is looking at stopped environments, this ensures the scope is passed to the HTTP call and that stopped environments in folders are fetched as well.

Remove new environments table feature flag

Cleans up the feature tests for the environmetns page as well, making sure they pass with the new table.

Changes are shockingly minimal, which is nice.

Changelog: changed

Screenshots or screen recordings

Screencast_2022-03-03_14_59_45

How to set up and validate locally

  1. Enable runners in your GDK/Gitpod -- see instructions
  2. Then add the following .gitlab-ci.yml to a project for some deployments:
stages:
    - deploy
    - stop
image: alpine:latest

deploy-prod:
    stage: deploy
    script:
        - sleep 6000
        - echo "deploying prod"
    environment:
        name: production

deploy-staging:
    stage: deploy
    script:
        - echo "deploying staging"
    environment:
        name: staging
        url: https://example.com
    when: manual

deploy-review:
    stage: deploy
    script:
        - echo "Deploying review/$CI_COMMIT_REF_NAME"
    environment:
        name: review/$CI_COMMIT_REF_NAME
        auto_stop_in: 1 week
    only:
        - branches
    except:
        - main


stop_review_app:
  script: stop-review-app
  stage: stop
  environment:
    name: review/$CI_COMMIT_REF_SLUG
    action: stop
  rules:
    - if: $CI_MERGE_REQUEST_ID
      when: manual

Run a pipeline to create environments.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Andrew Fontaine

Merge request reports