Skip to content

Refactor `Google Cloud :: Service Account` creation workflow

Sri Rang requested to merge incubation-5mp-branches-not-environments into master

What does this MR do and why?

Introduce a series of minor fixes and improvements to the Google Cloud :: Service Account Creation workflow before the private rollout scheduled for March / April.

  • Use refs (branches / tags) to determine protected state of service account CI vars. This achieves consistency / backward compatibility with original AWS five minute production prototype. It also eliminates EE specific code, thus making 5mp entirely open source.

  • Frontend table component's tableFields is not reactive, thus it is now a top-level property for the component.

  • Use permitted_params for the create request. Security enhancement.

  • Update existing variable, do not destroy and then recreate. Efficient DB queries.

  • Serialize refs to only include required properties

  • Namespace strings

Screenshots or screen recordings

service-accounts-refactired

How to set up and validate locally

  1. Enable incubation_5mp_google_cloud feature flag for a test project
  2. In GitLab web ui, navigate to project
  3. Go to Infra :: Google Cloud page
  4. Follow the create service account workflow.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Sri Rang

Merge request reports