Skip to content

Update projects_enforcing_code_owner_approval descriptions

Martin Brümmer requested to merge mbruemmer-master-patch-13893 into master

What does this MR do and why?

For the metrics usage_activity_by_stage_monthly.create.projects_enforcing_code_owner_approval and usage_activity_by_stage.create.projects_enforcing_code_owner_approval the metrics dictionary lists the descriptions as

Count of total projects that require approval by code owners for code changes.

However, the actual query counts the distinct users (as expected for a usage_activity type metric):

SELECT COUNT(DISTINCT "projects"."creator_id") FROM "projects" INNER JOIN "protected_branches" ON "protected_branches"."project_id" = "projects"."id" WHERE "protected_branches"."code_owner_approval_required" = TRUE AND "projects"."created_at"

The correct descriptions should be

Count of unique users creating projects that require approval by code owners for code changes and

Count of monthly unique users creating projects that require approval by code owners for code changes respectively.

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports