Update Secret Detection template

changed milestone to %14.8

added Category:Secret Detection backend featureenhancement groupstatic analysis sectionsec labels

assigned to @zrice

2 Warnings

featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.

For more information, see:

The Handbook page on merge request types.
The definition of done documentation.

You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the ~"type::tooling", ~"tooling::pipelines", ~"tooling::workflow", , labels.

	1 Message
	This merge request adds or changes files that require a review from the CI/CD Templates maintainers.

This merge request requires a CI/CD Template review. To make sure these changes are reviewed, take the following steps:

Ensure the merge request has the citemplates label. If the merge request modifies CI/CD Template files, Danger will do this for you.
Prepare your MR for a CI/CD Template review according to the template development guide.
Assign and @ mention the CI/CD Template reviewer suggested by Reviewer Roulette.

The following files require a review from the CI/CD Templates maintainers:

lib/gitlab/ci/templates/Jobs/Secret-Detection.gitlab-ci.yml

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
citemplates	Hordur Freyr Yngvason (`@hfyngvason`) (UTC-5, 1 hour ahead of `@zrice`)	Matija Čupić (`@matteeyah`) (UTC+1, 7 hours ahead of `@zrice`)

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

Generated by Danger

added 1 commit

a9f791af - Add newline at EOF

Compare with previous version

@matteeyah this pipeline passes no problem. WDYT about moving forward with this MR instead?

requested review from @matteeyah

Setting label(s) devopssecure based on groupstatic analysis.

added devopssecure label

approved this merge request

@matteeyah, thanks for approving this merge request.

This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.

For more info, please refer to the following links:

Looks good on the citemplates side of things, thanks Zach.

To explain further why I wanted to change the rules updates from the script updates - In case there's a problem with one of them and we need to revert this, we'll have to revert both changes instead of compartmentalizing and reverting just one (which is more work for the author).

removed review request for @matteeyah

@vij would you mind giving this a backend review? For more discussion you can see a previously open MR with these changes: !79985 (closed)

requested review from @vij

mentioned in merge request !79985 (closed)

mentioned in issue #351693 (closed)

added 1 commit

3e02ac0a - Remove changes in rules

Compare with previous version

mentioned in issue #352565 (closed)

approved this merge request

requested review from @marcel.amirault and removed review request for @vij

mentioned in issue #350660 (closed)

removed review request for @marcel.amirault

mentioned in issue biomedit/portal#539 (closed)

mentioned in issue #254199 (closed)

mentioned in issue #350573 (closed)

changed milestone to %14.9

added missed:14.8 label

added 2 commits

1a8bfc0f - Check previous git log command exit code
c51ff67f - Check previous git log command exit code

Compare with previous version

requested review from @marcel.amirault

removed review request for @marcel.amirault

requested review from @marcel.amirault

removed review request for @marcel.amirault

added 1 commit

68344ae0 - Use set +e to ignore git log failure

Compare with previous version

requested review from @marcel.amirault

requested review from @matteeyah and removed review request for @marcel.amirault

removed review request for @matteeyah

added 1 commit

ebc2e2dd - Consistent newlines, re-enable failure on exit

Compare with previous version

requested review from @marcel.amirault, @theoretick, and @matteeyah

removed review request for @theoretick

removed review request for @marcel.amirault

removed review request for @matteeyah

added 1 commit

c15c7242 - Remove extra MR conditional

Compare with previous version

requested review from @marcel.amirault

approved this merge request

mentioned in merge request !81847 (merged)

changed the description

approved this merge request

resolved all threads

mentioned in issue #354078

@zrice Thank you so much for all the hard work and sticking through with it! (also, thanks for your patience with my reviews, takes me a bit longer than the engineers that think code all day every day ). I'm glad to be able to merge this for you, LGTM!