Skip to content

Fix cross modification table in Ci::UpdateBuildQueueService

Max Orefice requested to merge mo-crossdatabasemodificationacrossunsupportedtableserror-in-ci-updatebuildqueueservice into master

Ref: #351847 (closed)

What does this MR do and why?

This MR fixes a cross database query happening once a month when pushing a build to our Ci::PendingBuild queue (currently 2 instances on sentry).

When we create a new entry to our queuing system, we wrap this up within a build transaction.

However as we identified with the team, we are also updating the namespace#extra_shared_runners_minutes_limit in this transaction which will not work once we will have 2 databases.

Note

This is some ~"technical debt" that will get clean up in %14.10 once we will use Ci::Minutes::AdditionalPack which will no longer produce a cross database query.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Max Orefice

Merge request reports