Extract SAML refactoring from metadata MR
What
Extract various changes from https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/5782:
- Allows SAML settings for a group to be calculated before it is persisted
- Cleans up
OmniAuth::Strategies::GroupSaml
Why
That MR has stalled due to changes needed for TokenAuthenicable, so I'd like to get unrelated changes merged to avoid conflict/duplication later.
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated -
Tests added for this feature/bug -
Conforms to the code review guidelines -
Conforms to the merge request performance guidelines -
Conforms to the style guides -
Conforms to the database guides -
EE specific content should be in the top level /eefolder -
For a paid feature, have we considered GitLab.com plans, how it works for groups, and is there a design for promoting it to users who aren't on the correct plan?
Edited by Kamil Trzciński