Skip to content

Fix quarantined custom award emoji spec

Simon Knox requested to merge 351878-spec-failure-in-spec-features-issues-user_interacts_with_awards_spec-rb-user-interacts-with into master

What does this MR do and why?

check that award count is immediately updated on click then stays that way once network request completes

Related to #351878 (closed)

What I think was happening

This was the failure:

Failures:
  1) User interacts with awards User interacts with awards in an issue toggles a custom award emoji
     Got 1 failure and 1 other error:
     1.1) Failure/Error:
            expect do
              page.find('[data-testid="award-button"].selected').click
              wait_for_requests
            end.to change { page.all('[data-testid="award-button"]').size }.from(3).to(2)
            expected `page.all('[data-testid="award-button"]').size` to have changed from 3 to 2, but did not change

We were clicking the button too fast, so the button was not being removed (#351266)

Now we wait for requests to complete after first clicking the button, so the second click (correctly) removes it

Edited by Simon Knox

Merge request reports