Skip to content
Snippets Groups Projects

Allow urlText to be saved on metric images

Merged Sean Arnold requested to merge 346171-frontend-for-metric-image-url-text into master

What does this MR do and why?

This adds the ability to add a Url Text (text describing what the image or external URL is, i.e 'Production error rate').

It also adds the ability to update both the url and url_text fields on the metric image.

The backend for this change was added in !78430 (merged).

Screenshots or screen recordings

header header
Form Screen_Shot_2022-02-09_at_2.45.08_PM
URL with URL Text Screen_Shot_2022-02-09_at_2.45.28_PM

2022-02-09_14.47.03

How to set up and validate locally

  1. Ensure you have at least a GitLab Premium account.
  2. Head to Monitor -> Incidents and create an incident.
  3. Once created, add a metric via the metric tab.
  4. Add / Edit / Delete as you please.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #346171 (closed)

Edited by Sean Arnold

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Natalia Tepluhina
  • Natalia Tepluhina removed review request for @ntepluhina

    removed review request for @ntepluhina

  • Sean Arnold added 1 commit

    added 1 commit

    Compare with previous version

  • Sean Arnold added 1 commit

    added 1 commit

    • 47b92b86 - Add specs for edit modal behaviour

    Compare with previous version

  • Sean Arnold requested review from @ntepluhina

    requested review from @ntepluhina

  • Sean Arnold added 1 commit

    added 1 commit

    • 2c50c5d8 - Add specs for edit modal behaviour

    Compare with previous version

  • Natalia Tepluhina
  • Natalia Tepluhina resolved all threads

    resolved all threads

  • Natalia Tepluhina enabled an automatic merge when the pipeline for 69a9208a succeeds

    enabled an automatic merge when the pipeline for 69a9208a succeeds

  • mentioned in commit f88e9e0b

  • added workflowcanary label and removed workflowstaging label

  • added workflowproduction label and removed workflowcanary label

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading