Skip to content

Remove the `packages_installable_package_files` feature flag

David Fernandez requested to merge 348677-cleanup-feature-flag into master

🍐 Context

In !76767 (merged), we introduced a status attribute on the package file model.

This allows us to mark package files in certain ways that will remove them from being available in UIs and APIs.

This was quite a deep change (eg. all functions/finders/services that access package files). As such, we introduced it using a feature flag: packages_installable_package_files.

That feature flag has been enabled by default in %14.7. The reason is that self-managed users could have different conditions than gitlab.com. By using the "enable by default" approach, we provided a safety net for self-managed installations.

Now, we're in %14.8 and with no feedback on this change, we can safely remove the feature flag from the codebase.

🔬 What does this MR do and why?

  • Remove the packages_installable_package_files feature flag.

📸 Screenshots or screen recordings

See !76767 (merged)

⚙ How to set up and validate locally

See !76767 (merged)

🚥 MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports