Skip to content

Add ::Gitlab::Usage::ServicePingReport class

Alina Mihaila requested to merge am-remove-force-refresh-param-from-usage_data into master

What does this MR do and why?

Related #346640 (closed)

Described steps for new feature and refactoring steps #346640 (comment 829309319)

  • Move force_refresh outside UsageData class
  • Rename force_refresh to cached. In most of the cases, we need fresh values for Service Ping
  • Add ::Gitlab::Usage::ServicePingMetrics class and use this instead of UsageData
  • Add mode parameter to ServicePing::Generate class

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Example below:

  1. Generate Service Ping

    # uncached 
Gitlab::Usage::ServicePingMwtrics.for(mode: :values)

# cahced
Gitlab::Usage::ServicePingMetrics.for(mode: :values, cached: true)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Alina Mihaila

Merge request reports