Update auto-build-image to v1.5.0
What does this MR do and why?
This was a feature-flagged change, see rollout issue #337990 (closed)
We delete the feature flag here to prevent confusion in production if the latest template falls behind stable.
The latest template must, however, remain, as removing it is a breaking change.
Screenshots or screen recordings
These are strongly recommended to assist reviewers and reduce the time to merge your change.
How to set up and validate
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %14.8
added Deliverable ~16636198 devopsconfigure [DEPRECATED] featureenhancement sectionops workflowin dev labels
assigned to @hfyngvason
added typefeature label
- Resolved by Tiger Watson
- A deleted user
added backend label
2 Warnings featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the ~"type::tooling", ~"tooling::pipelines", ~"tooling::workflow", documentation, QA labels.1 Message This merge request adds or changes files that require a review from the CI/CD Templates maintainers. This merge request requires a CI/CD Template review. To make sure these changes are reviewed, take the following steps:
- Ensure the merge request has the citemplates label. If the merge request modifies CI/CD Template files, Danger will do this for you.
- Prepare your MR for a CI/CD Template review according to the template development guide.
- Assign and
@
mention the CI/CD Template reviewer suggested by Reviewer Roulette.
The following files require a review from the CI/CD Templates maintainers:
lib/gitlab/ci/templates/Jobs/Build.gitlab-ci.yml
lib/gitlab/ci/templates/Jobs/Build.latest.gitlab-ci.yml
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Shreyas Agarwal ( @shreyasagarwal
) (UTC+1, 6 hours ahead of@hfyngvason
)Douglas Barbosa Alexandre ( @dbalexandre
) (UTC-3, 2 hours ahead of@hfyngvason
)citemplates Lucas Charles ( @theoretick
) (UTC-8, 3 hours behind@hfyngvason
)Marcel Amirault ( @marcel.amirault
) (UTC+9, 14 hours ahead of@hfyngvason
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangermentioned in issue #337990 (closed)
added groupconfigure [DEPRECATED] label
added 1175 commits
-
1c3cd29a...b19f2af9 - 1174 commits from branch
master
- 8bd129ca - Update auto-build-image to v1.5.0
-
1c3cd29a...b19f2af9 - 1174 commits from branch
- Resolved by Douglas Barbosa Alexandre
@tigerwnz Can you please take the first citemplates and backend reviews?
requested review from @tigerwnz
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
requested review from @marcel.amirault and @dbalexandre and removed review request for @tigerwnz
@tigerwnz
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
removed review request for @marcel.amirault
enabled an automatic merge when the pipeline for 412f525a succeeds
Thanks, @hfyngvason! This LGTM
added workflowverification label and removed workflowin dev label
mentioned in commit 075476b8
added workflowstaging-canary label and removed workflowverification label
added workflowstaging label and removed workflowstaging-canary label
added workflowcanary label and removed workflowstaging label
mentioned in issue gitlab-com/www-gitlab-com#12284 (closed)
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!677 (merged)
added releasedpublished label and removed releasedcandidate label
added groupenvironments label and removed groupconfigure [DEPRECATED] label