Add margin for unlink icon in remove button

What does this MR do and why?

Describe in detail what your merge request does and why.

This adds a margin to the icon for Removing a SAML link.

Before:

After:

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

• I have evaluated the MR acceptance checklist for this MR.

added devopsmanage frontend groupauthentication and authorization [DEPRECATED] labels

requested review from @badnewsblair

assigned to @nelbacha

added 1 commit

• 54a07eeb - Make the remove button a bit bigger

Compare with previous version

@nelbacha I've added another change to make the button size match with that of the save button a few lines above it.

Allure report

allure-report-publisher generated test report!

review-qa-smoke: test report
review-qa-reliable: test report

review-qa-blocking: test report for 9ab48a75

expand test summary

+-------------------------------------------------------------------+
|                          suites summary                           |
+----------------------+--------+--------+---------+-------+--------+
|                      | passed | failed | skipped | flaky | result |
+----------------------+--------+--------+---------+-------+--------+
| Create               | 17     | 0      | 2       | 1     | ❗     |
| Verify               | 12     | 0      | 1       | 8     | ❗     |
| Manage               | 28     | 0      | 2       | 10    | ❗     |
| Plan                 | 41     | 0      | 1       | 1     | ❗     |
| Configure            | 0      | 0      | 1       | 0     | ➖     |
| Package              | 0      | 0      | 1       | 0     | ➖     |
| Version sanity check | 0      | 0      | 1       | 0     | ➖     |
| Protect              | 2      | 0      | 0       | 0     | ✅     |
+----------------------+--------+--------+---------+-------+--------+
| Total                | 100    | 0      | 9       | 20    | ❗     |
+----------------------+--------+--------+---------+-------+--------+

@nelbacha The icon margin looks good, thank you.

@asmaa.hassan I want to make sure the height of the button is consistent with "button-icon-and-text" in Pajamas.

Setting label(s) ~"Category:Authentication and Authorization" sectiondev based on ~"group::authentication and authorization".

added sectiondev + 1 deleted label

@nelbacha, please can you answer the question: Should this have a feature flag? to help with code review for the Access group.

This nudge was added by this triage-ops policy.

approved this merge request

@badnewsblair, thanks for approving this merge request.

This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.

For more info, please refer to the following links:

• rspec minimal jobs
• jest minimal jobs
• merging a merge request.

	43 Warnings
	5db54a84: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines.
	ef61b0f0: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
	328fee4d: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines.
	20f451ad: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
	c03d5b8f: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
	e80d621a: The commit subject may not be longer than 72 characters. For more information, take a look at our Commit message guidelines.
	e848e5e0: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
	382c653c: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines.
	e2c8b713: The commit subject may not be longer than 72 characters. For more information, take a look at our Commit message guidelines.
	c88b7a84: The commit subject may not be longer than 72 characters. For more information, take a look at our Commit message guidelines.
	6b33986d: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines.
	ed97fc57: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines.
	57fc70d9: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines.
	0a61f731: The commit subject must start with a capital letter. For more information, take a look at our Commit message guidelines.
	0cd315eb: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
	ba59f471: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
	c027920b: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
	ef688d84: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
	db0c1d75: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
	3b2f7d27: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
	9b564bbb: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines.
	09d5bf5e: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
	92287e52: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
	4898697d: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
	3b1a8873: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
	4c458201: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines.
	07f0198f: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
	03d43c3e: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
	988f8d53: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
	34efffe8: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines.
	91a7c32b: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines.
	51f3ff91: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines.
	c56b1e8b: The commit subject must start with a capital letter. For more information, take a look at our Commit message guidelines.
	9fa2197f: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
	97dfd052: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
	a6715533: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
	20c58a93: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
	e6835d78: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
	ae28a03f: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
	80863e73: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
	111a1245: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines.
	You've made some app changes, but didn't add any tests. That's OK as long as you're refactoring existing code, but please consider adding any of the ~"type::tooling", ~"tooling::pipelines", ~"tooling::workflow", documentation, QA labels.
	Please add a merge request type to this merge request.

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
frontend	Miranda Fluharty (@mfluharty) (UTC+1)	Olena HK. (@ohoral) (UTC+3)

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

mentioned in merge request !82161 (closed)

mentioned in issue gitlab-org/quality/triage-reports#7104 (closed)

changed milestone to %15.0

requested review from @eduardosanz

approved this merge request

removed review request for @eduardosanz

requested review from @iamphill

Hi @iamphill would be please check and merge this MR?

removed review request for @iamphill

added 1 commit

• 6615e356 - Use btn-md class instead of btn-sm-5 for the Remove button

Compare with previous version

resolved all threads

requested review from @iamphill

added 12003 commits

• 6615e356...165f8a2e - 12002 commits from branch master
• 84da093b - Merge branch 'master' into 'add-margin-for-unlink-saml-button'

Compare with previous version

approved this merge request

enabled an automatic merge when the pipeline for b845c808 succeeds

Suggested Reviewers (beta)

This is an experimental ML-based code reviewer recommendation system created by ~"group::applied ml".

The individuals below may be good candidates to participate in the review based on various factors.

After you review all recommendations, please assign reviewers manually, as this is not done automatically.

You can use slash commands in comments to quickly assign /assign_reviewer @user1.

Reviewers
@iamphill, @dstull, @blabuschagne, @himkp, @xanf

If you do not believe these recommendations are useful or if you do not want to use any of the suggestions, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue: https://gitlab.com/gitlab-org/gitlab/-/issues/357923.

Automatically generated by Suggested Reviewers Bot

	2 Warnings
	Please add a merge request type to this merge request.
	You've made some app changes, but didn't add any tests. That's OK as long as you're refactoring existing code, but please consider adding any of the maintenancepipelines, maintenanceworkflow, documentation, QA labels.

	1 Message
	CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the Changelog trailer to the commit message you want to add to the changelog. If you want to create a changelog entry for GitLab EE, also add the EE: true trailer to your commit message. If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

If needed, you can retry the danger-review job that generated this comment.

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
backend	Kassio Borges (@kassio) (UTC+2)	Thong Kuah (@tkuah) (UTC+12)
frontend	Stanislav Lashmanov (@slashmanov) (UTC+4)	Jiaan Louw (@jiaan) (UTC+2)

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

Generated by Danger

aborted the automatic merge because source branch was updated

added 530 commits

• 84da093b...19db0236 - 529 commits from branch master
• 9ab48a75 - Add margin for unlink icon in remove button

Compare with previous version

enabled an automatic merge when the pipeline for bf03af64 succeeds

merged

mentioned in commit bff3f78e

added workflowstaging-canary label

added workflowcanary label and removed workflowstaging-canary label

added workflowstaging label and removed workflowcanary label

added workflowproduction label and removed workflowstaging label

added releasedcandidate label