Remove line-height on branch name in merge request
What does this MR do and why?
The branch name in the link to a branch on an unmerged merge request has
overflow: hidden set. This means that setting the line-height setting
too small has the effect of truncating certain low descenders, like
underscore characters in certain fonts.
Removing the line height setting causes the text to move up slightly, no longer lining up with the rest of the line, but we can fix that by moving the margin bottom offset down a bit more to acommodate that.
Screenshots or screen recordings
- Before:
- After:
How to set up and validate locally
- Create a branch with underscores in its name:
git checkout -b test_branch_with_underscores - Push that branch to a repo on GitLab:
git push origin test_branch_with_underscores - Create a merge request for that branch; for example, navigate to the project in GitLab, and click on the link to create a merge request for the branch that you recently pushed. Fill out the merge request details and submit.
- View the merge request, and check to see if you can see the underscores in the branch name.
Note that this issue may only be present on certain browsers, operating systems, or with certain fonts. The users who noticed this were using Firefox on Linux on a variety of Linux distributions, with DejaVu Sans Mono as their fixed-width font
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.