Skip to content

REST: Fix scope of /groups/:id/runners?type endpoint

Pedro Pombeiro requested to merge pedropombeiro/337690/1-rest-api-fix-type-scopes into master

What does this MR do and why?

Describe in detail what your merge request does and why.

This MR fixes the GET /groups/:id/runners?type=instance_type endpoint to return the list of instance runners. Currently, it was always returning an empty list. It also fixes the documentation to match the implementation.

See #337690 (comment 825034441)

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Assuming you have a local GDK setup with some instances runners, you should be able to see them from a group, issuing a REST call such as:

$ xh GET "http://gdk.test:3000/api/v4/groups/28/runners?type=instance_type" PRIVATE-TOKEN:${YOUR_PRIVATE_TOKEN}

By contrast, the master branch implementation returns an empty collection.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Part of #337690 (closed)

Edited by Pedro Pombeiro

Merge request reports