Skip to content

Remove flash notice check when member leaves project by url param

Valerie Burton requested to merge remove-flash-notice-check-when-member-leaves-project into master

What does this MR do and why?

Since asserting on flash notice banners had historically caused flakiness for specs in the past, this MR removes expect(find('.flash-notice')).to have_content "You left the \"#{project.full_name}\" project".

In its place, I've instead added a check to log in as project.first_owner and verify the user is no longer listed in the list of project members. I've also removed the db check against project users as that is outside the concern of a feature spec.

This should hopefully resolve the frequent failures as reported in #35925 (closed)

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Valerie Burton

Merge request reports