Fix duplicate draft help text
What does this MR do and why?
Closes #348824 (closed)
Screenshots or screen recordings
Before | After |
---|---|
Screen_Recording_2022-02-10_at_18.10.06 | Screen_Recording_2022-02-11_at_11.24.20 |
How to set up and validate locally
- Go to create
New merge request
page - Refresh the page
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %14.8
added UI polish UX frontend groupcode review merge requests typebug labels
assigned to @slashmanov
- Resolved by Annabel Dunstone Gray
@thomasrandolph hi!
Could you please take a look at this when you have time?
requested review from @thomasrandolph
2 Warnings This merge request changed files with disabled eslint rules. Please consider fixing them. You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the ~"type::tooling", ~"tooling::pipelines", ~"tooling::workflow", documentation, QA labels.Disabled eslint rules
The following files have disabled
eslint
rules. Please consider fixing them:app/assets/javascripts/issuable/issuable_form.js
Run the following command for more details
node_modules/.bin/eslint --report-unused-disable-directives --no-inline-config \ 'app/assets/javascripts/issuable/issuable_form.js'
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Angelo Gulina ( @agulina
) (UTC+1)Natalia Tepluhina ( @ntepluhina
) (UTC+1)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerAllure report
allure-report-publisher
generated test report for b824b9ac!review-qa-smoke:
test report
review-qa-reliable: test reportadded 233 commits
-
f9f651bc...a5331e77 - 232 commits from branch
master
- cf4c0068 - Fix duplicate draft help text
-
f9f651bc...a5331e77 - 232 commits from branch
Setting label(s) devopscreate sectiondev based on groupcode review.
added devopscreate sectiondev labels
requested review from @ohoral and removed review request for @thomasrandolph
@thomasrandolph
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
- Resolved by Olena Horal-Koretska
@annabeldunstone hi!
Could you please have a look at this MR? Maybe there's something to improve on the UX side of things?
We can not completely get rid of the blinking text effect unfortunately, so we have to play around that.
requested review from @annabeldunstone
removed review request for @annabeldunstone
@slashmanov @annabeldunstone I prefer the separate sentences too.
added 1804 commits
-
cf4c0068...37856ef5 - 1803 commits from branch
master
- c22cf2b5 - Fix duplicate draft help text
-
cf4c0068...37856ef5 - 1803 commits from branch
requested review from @annabeldunstone
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits d1fb9295 and b824b9ac
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.66 MB 3.67 MB +12.18 KB 0.3 % mainChunk 2.29 MB 2.29 MB - 0.0 % Significant Growth: 54Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.projects.shared.permissions 859.61 KB 883.82 KB +24.21 KB 2.8 % pages.projects.work_items 898.61 KB 922.39 KB +23.77 KB 2.6 % pages.groups.settings.packages_and_registries.show 704.09 KB 727.47 KB +23.38 KB 3.3 % pages.projects 801.87 KB 825.24 KB +23.38 KB 2.9 % pages.projects.activity 810.63 KB 834.01 KB +23.38 KB 2.9 % pages.projects.artifacts.browse 803.69 KB 827.07 KB +23.38 KB 2.9 % pages.projects.artifacts.file 813.63 KB 837 KB +23.38 KB 2.9 % pages.projects.blame.show 901.12 KB 924.49 KB +23.38 KB 2.6 % pages.projects.blob.edit 886.94 KB 910.32 KB +23.38 KB 2.6 % pages.projects.blob.new 886.94 KB 910.32 KB +23.38 KB 2.6 % The table above is limited to 10 entries. Please look at the full report for more details
Significant Reduction: 51Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.groups.group_members 647.12 KB 618.21 KB -28.91 KB -4.5 % sentry 171 KB 150.94 KB -20.07 KB -11.7 % pages.groups.wikis.diff 142.15 KB 125.15 KB -17 KB -12.0 % pages.admin.geo.nodes 216.45 KB 200.16 KB -16.3 KB -7.5 % pages.admin.geo.nodes.edit 269.1 KB 252.8 KB -16.3 KB -6.1 % pages.admin.geo.nodes.new 269.1 KB 252.8 KB -16.3 KB -6.1 % jira_connect_app 219.26 KB 204.83 KB -14.42 KB -6.6 % pages.admin.application_settings 343.67 KB 329.25 KB -14.42 KB -4.2 % pages.admin.application_settings.advanced_search 345.66 KB 331.23 KB -14.42 KB -4.2 % pages.admin.application_settings.ci_cd 352.7 KB 338.28 KB -14.42 KB -4.1 % The table above is limited to 10 entries. Please look at the full report for more details
Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.
Please consider pinging someone from the FE Foundations (
@dmishunov
,@justin_ho
,@mikegreiling
or@nmezzopera
) for review, if you are unsure about the size increase.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangerremoved review request for @annabeldunstone
requested review from @annabeldunstone
removed review request for @annabeldunstone
- Resolved by Olena Horal-Koretska
- Resolved by Olena Horal-Koretska
- Resolved by Olena Horal-Koretska
enabled an automatic merge when the pipeline for e40b25ef succeeds
mentioned in commit 1c4b1246
mentioned in issue #348824 (closed)
added workflowstaging-canary label
added workflowstaging label and removed workflowstaging-canary label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!677 (merged)
added releasedpublished label and removed releasedcandidate label