Skip to content

Revert "Merge branch '350152-purge-request-profiler' into 'master'"

Roy Zwambag requested to merge revert-1a8b8581 into master

What does this MR do and why?

We originally removed the Gitlab::RequestProfiler, since it was not used by GitLab team members. In this thread @mkaeppler rightly pointed out that it is a customer feature and might be used by self-managed customers. Looping in the ~"group::monitor", this seems indeed a possibility. So we revert the changes since we shouldn't remove it without deprecating it first (the future state of this code is still being discussed).

Skipping undercoverage because the original code had insufficient coverage. I don't want to introduce new code in this revert MR. And it seems like a waste of time to add specs for code that might be dropped in the (near) future

So this is just a revert of removing code, no new code is added at all

Original MR: !78911 (merged)

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Visit <gdk>/admin/requests_profiles
  2. Follow instructions on how to profile on this page
  3. See the profiles appear on this page

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Roy Zwambag

Merge request reports