Skip to content

Fix use of ActiveRecord::Base in CurrentSettings

Matt Kasa requested to merge 350651-fix-remaining-code-offenses-using-activerecord-base-methods into master

What does this MR do and why?

Fixes CurrentSettings to call methods on ApplicationSetting instead of ActiveRecord::Base because ActiveRecord::Base may not be the correct database due to database decomposition.

See #350651 (closed)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #350651 (closed)

Edited by Matt Kasa

Merge request reports