Skip to content

Fix global_alert when using fluid layout

Justin Ho Tuan Duong requested to merge justin_ho-fix-global-alert-when-on-fluid-layout into master

What does this MR do and why?

When using Fluid layout, we now don't need to use the gl-alert-layout-limited class. Instead, we let the container decide what the width of the Alert should be.

This change cleans up the HAML view and updates specs around this new behaviour.

Changelog: changed

Screenshots or screen recordings

Version Before After
Fixed layout global_alert_fixed_-_before global_alert_fixed_-_after
Fluid layout global_alert_fluid_-_before global_alert_fluid_-_after

How to set up and validate locally

  1. Visit any page that uses global_alert.
  2. Change between Fixed and Fluid layouts in User > Preferences http://127.0.0.1:3000/-/profile/preferences

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Justin Ho Tuan Duong

Merge request reports