Skip to content

Canary toggle compatible with next.gitlab.com

Robert Speicher requested to merge rs-toggle-canary-next-compat into master

What does this MR do and why?

Previously the g x hotkey would set the cookie on the root domain only (i.e., gitlab.com), whereas our next.gitlab.com implementation uses .gitlab.com with a leading period.

See #350186 (closed).

How to set up and validate locally

  1. Ensure GDK is configured to use a hostname such as gdk.test (see documentation)
  2. Navigate to a GDK page
  3. Enter g x hotkey
  4. Validate a canary_gitlab cookie was written with the domain as .gdk.test

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Robert Speicher

Merge request reports