Skip to content

New feature tests for validating integration settings from

Sean Gregory requested to merge qa/feature_tests_integration_settings into master

What does this MR do and why?

These tests add test coverage at the feature level for the integrations settings form within every CE integration.

The strategy is fetch a list of applicable integrations and

  • visit the form for them
  • validate the existence of the activation field
  • validate the existence of the integration specific fields

There are a couple of spec implementation details that don't currently match the app.

  • Integration.available_integration_names includes "GitHub" which is only available on EE
  • integration.fields does not include applicable _events checkboxes for some integrations, and includes inapplicable _channel fields for others

Due to these mismatches some specs will currently not pass

The intent of this MR will be to add an EE spec for the GitHub integration, and validate that the fields show up correctly for every integration.

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

  1. bundle exec rspec spec/features/projects/integrations/integrations_settings_form_spec.rb

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Sean Gregory

Merge request reports