Chart showing issues created per month
What does this MR do?
This MR adds a chart showing issues created per month for groups.
| Issues Chart | Empty State (No Data) | Empty State (Filters) |
|---|---|---|
 |
 |
 |
closes #7478 (closed)
What are the relevant issue numbers?
Does this MR meet the acceptance criteria?
-
Changelog entry added, if necessary -
Documentation created/updated -
Tests added for this feature/bug -
Conforms to the code review guidelines -
Conforms to the merge request performance guidelines -
Conforms to the style guides -
Conforms to the database guides -
EE specific content should be in the top level /eefolder -
For a paid feature, have we considered GitLab.com plans, how it works for groups, and is there a design for promoting it to users who aren't on the correct plan? Yes, this is handled in https://gitlab.com/gitlab-org/gitlab-ee/issues/8037.
Merge request reports
Activity
4 Warnings 
This merge request is quite big (more than 1048 lines changed), please consider splitting it into multiple merge requests. This merge request is missing the database label. This merge request includes more than 10 commits. Please rebase these commits into a smaller number of commits. This merge request changed frontend files without pretty printing them. 2 Messages 
This merge request adds or changes files that require a review from the Database team. This merge request adds or changes files that require a review from the docs team. Database Review
The following files require a review from the Database team:
db/fixtures/development/09_issues.rb
To make sure these changes are reviewed, take the following steps:
- Edit your merge request, and add
gl-databaseto the list of Group approvers. - Mention
@gl-databasein a separate comment, and explain what needs to be reviewed by the team. Please don't mention the team until your changes are ready for review.
Docs Review
The following files require a review from the Documentation team:
doc/README.mddoc/user/group/index.mddoc/user/group/issues_analytics/img/issues_created_per_month.pngdoc/user/group/issues_analytics/index.md
To make sure these changes are reviewed, mention
@gl-docsteamin a separate comment, and explain what needs to be reviewed by the team. Please don't mention the team until your changes are ready for review.Pretty print Frontend files
The following files should have been pretty printed with
prettier:ee/app/assets/javascripts/issues_analytics/stores/modules/issue_analytics/getters.js
Please run
node_modules/.bin/prettier --write \ 'ee/app/assets/javascripts/issues_analytics/stores/modules/issue_analytics/getters.js'Also consider auto-formatting on-save.
Generated by
Edited by 🤖 GitLab Bot 🤖@okoghenun Are you the one going to work on this?
- Added
analyticssub-menu to groups sidebar under the issues menu - Added license check
- Chart data is being generated as a hash (let me know if other thing is needed like an array)
- to generate some consistent chart data just run
rake db:seed_fuit will create issues in all projects with random creation dates. If you don't want to run the wholerake db:seed_fujust run to create issues withrake db:seed_fu FILTER=09
- Added
@felipe_artur Yes, I will be working on the FE for this.
added 1 commit
- c1264893 - Added filtered search to Issues Analytics page
added 2 commits
assigned to @jprovaznik
@jprovaznik can you review backend please?
It is just missing a controller spec.
Thanks @felipe_artur, nice stuff, I left some comments inline.
assigned to @felipe_artur
added 2 commits
- 6f339588 - Added loading state to the design
- d1fab628 - Merge branch 'issue_7478' of https://gitlab.com/gitlab-org/gitlab-ee into issue_7478
added 436 commits
-
d1fab628...916bc63c - 434 commits from branch
master - abc5c7a4 - Merge branch 'master' into issue_7478
- c1614223 - Merge branch 'issue_7478' of gitlab.com:gitlab-org/gitlab-ee into issue_7478
-
d1fab628...916bc63c - 434 commits from branch
added 1 commit
- e801239d - Address review comments and add spec for controller
marked the checklist item Changelog entry added, if necessary as completed
marked the checklist item Tests added for this feature/bug as completed
Thanks for the great reaview @jprovaznik!
Adressed your comments and answered some questions.
Please let me know if you have any additional remarks or suggestions?
Otherwise i will send for final review.marked the checklist item Documentation created/updated as completed
This is one of the items from the Merge request template:
For a paid feature, have we considered GitLab.com plans, how it works for groups, and is there a design for promoting it to users who aren't on the correct plan?
Are we going to promote this?
Edited by Felipe Cardozo
Thanks @felipe_artur ! I think we should scope that separately. I created https://gitlab.com/gitlab-org/gitlab-ee/issues/8037 and linked to it in the description here.
assigned to @jprovaznik
Thanks @felipe_artur, LGTM (the backend part), I'm still little bit concerned about the model name, but feel free to leave it for a maintainer review if you prefer this.
assigned to @felipe_artur
@jprovaznik Thank you!
I changed the model name, your suggestion makes more sense.
added documentation label
added 4 commits
- c30b1e51 - Move issue ananlytics javascript to ee folder
- e9ffeb8f - Created Issue Analytics compoenent
- a1e5cb85 - Added chart to issue analytics component
- 34cc86e3 - Merge branch 'issue_7478' of https://gitlab.com/gitlab-org/gitlab-ee into issue_7478
Toggle commit listadded 1 commit
- bf466e1a - Updated the syling of issue analytics bar charts
added 2 commits
