Skip to content

Move the MemoryProfiler to the Performance Bar

Roy Zwambag requested to merge rz-memory-report-pb-poc into master

What does this MR do and why?

With #350152 (closed) we reviewed Gitlab::RequestProfiler. It seems mostly unused, and we get similar reports with stackprof in the performance bar, so we plan on removing Gitlab::RequestProfiler (See !78911 (merged)). Gitlab::RequestProfiler also has the option to generate Memory Reports with the memory_profiler gem. This can be super helpful, so we decided to keep this functionality, but move it to a more accessible place, the performance bar instead of the Admin area.

Documentation will be added in #352403 (closed)

Re the length of the performance bar, an issue is created for that: #352360

Screenshots or screen recordings

Screenshot_2022-01-25_at_11.20.02

Screenshot_2022-01-25_at_11.19.54

How to set up and validate locally

Run Gitlab in development mode

  1. Go to any page
  2. Open the performance bar (p+b)
  3. Click on Memory Report
  4. A new page with the report as plain text should open up

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #350152 (closed)

Edited by Roy Zwambag

Merge request reports