Skip to content

Add gitlab_shell_upload_pack_sidechannel feature flag

Jacob Vosmaer requested to merge jv-gitlab-shell-sidechannel into master

What does this MR do and why?

This feature flag sets the use_sidechannel field to true or false in the response from POST /api/v4/internal/allowed.

This implements gitlab-com/gl-infra/scalability#1515 (closed) and is part of gitlab-com/gl-infra&652 (closed).

The other side of this change is in gitlab-shell!557 (merged). After that, we will still need a gitlab-shell version bump. It does not matter in which order we merge things because gitlab-shell will default to the old behavior whether the new use_sidechannel is absent or set to false. In other words, nothing interesting happens until after we merge (1) this MR, (2) gitlab-shell!557 (merged), (3) the required gitlab-shell version bump MR, and (4) we enable the feature flag.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Jacob Vosmaer

Merge request reports