Skip to content

Clean up usages of subscriptions plans url

Vamsi Vempati requested to merge 3637-clean-up-plans-code into master

What does this MR do and why?

Cleans up usages of subscriptions plans url

  • Replace usages of subscriptions_plans_url with pricing URL
  • Remove definition for unused subscriptions_plans_url
  • Update tests for the above clean up

Screenshots or screen recordings

Concern Before After
Subscription purchase Screen_Shot_2022-01-20_at_12.24.02_PM Screen_Shot_2022-01-20_at_11.45.24_AM
Upgrade menu item Screen_Shot_2022-01-20_at_12.26.54_PM Screen_Shot_2022-01-20_at_11.25.55_AM
Promote issue weights Screen_Shot_2022-01-20_at_12.22.40_PM Screen_Shot_2022-01-20_at_11.59.02_AM
Promote epics Screen_Shot_2022-01-20_at_12.26.08_PM Screen_Shot_2022-01-20_at_12.18.11_PM

How to set up and validate locally

  1. Check if Buy Subscription button on SubscriptionPurchaseCard takes to pricing page when there isn't a valid license or valid subscription present
  2. Check if the "Upgrade 🚀" menu item in user menu takes us to pricing URL for an upgradeable namespace
  3. Check if Premium plan link under Weight section for an upgradeable weight feature takes us to pricing link
  4. Check if Buy EE link in Upgrader modal under Epic section for an upgradeable epic feature takes us to pricing link

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to customers-gitlab-com#3637 (closed)

Edited by Vamsi Vempati

Merge request reports