Skip to content

Swap FK dast_profiles_pipelines.ci_pipeline_id to ci_pipelines for LFK

Douglas Barbosa Alexandre requested to merge remove-ci_pipelines_dast_profiles_pipelines_ci_pipeline_id-fk into master

What does this MR do and why?

Per &7249 (closed)

As part of our CI "decomposition" efforts we need to remove all foreign keys that are cross-database (ie. between the planned main and ci databases). We are going to replace them all with "loose foreign keys".

Related: #348272 (closed)

Validations

  • Best team to review (check off when reviewed): groupdynamic analysis devopssecure
  • No way for user to access once parent is deleted. Please explain:
  • Possible to access once parent deleted but low user impact. Please explain: @philipcunningham FK is used primarily to track which DAST profile triggered a CI pipeline and is it not leveraged by any user-facing functionality. If the CI pipeline is deleted, the DAST profile may still be accessed but the user-experience will not be affected.
  • Possible Sidekiq workers that may load directly and possibly lead to exceptions. Please explain:
  • Possible user impact to be evaluated or mitigated. Please explain:

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Douglas Barbosa Alexandre

Merge request reports