Skip to content

Swap FK ci_triggers.owner_id to users for LFK

Kamil Trzciński requested to merge remove-users_ci_triggers_owner_id-fk into master

What does this MR do and why?

Per &7249 (closed)

As part of our CI "decomposition" efforts we need to remove all foreign keys that are cross-database (ie. between the planned main and ci databases). We are going to replace them all with "loose foreign keys".

Related to: #348268 (closed)

Validations

  • Best team to review (check off when reviewed): grouptesting devopsverify

  • No way for user to access once parent is deleted. Please explain:

  • Possible to access once parent deleted but low user impact. Please explain:

    The trigger can be accessed:

    • in the CI/CD settings page, but it shows as invalid
    • using the API, but it returns 40X status on POST/PUT

  • Possible Sidekiq workers that may load directly and possibly lead to exceptions. Please explain:

  • Possible user impact to be evaluated or mitigated. Please explain:

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Marius Bobin

Merge request reports