Remove `net-ssh`, `ed25519`, and `bcrypt_pbkdf` gems from dependencies
What does this MR do and why?
Follow up !77424 (comment 812526274)
In !77424 (merged) we started
using ssh_data
gem instead of net-ssh
and sshkey
where possible to facilitate implementation of
#213259 (closed).
This MR eliminates the last usage of net-ssh
from the codebase
and removes net-ssh
and its sub dependencies - ed25519
and bcrypt_pbkdf
.
Fewer dependencies facilitate development and maintenance, especially during upgrading libraries/gems.
Changelog: other
Screenshots or screen recordings
These are strongly recommended to assist reviewers and reduce the time to merge your change.
How to set up and validate locally
bin/rspec spec/validators/x509_certificate_credentials_validator_spec.rb
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
assigned to @bdenkovych
changed milestone to %14.8
- A deleted user
added backend label
2 Warnings 91a7c32b: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines. You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the ~"type::tooling", ~"tooling::pipelines", ~"tooling::workflow", documentation, QA labels.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Alina Mihaila ( @alinamihaila
) (UTC+2, same timezone as@bdenkovych
)James Fargher ( @proglottis
) (UTC+13, 11 hours ahead of@bdenkovych
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Imre Farkas
added sectiondev typemaintenance labels
removed sectiondev label
- Resolved by Imre Farkas
mentioned in merge request !77424 (merged)
added 1 commit
- 2a143729 - Remove `net-ssh`, `ed25519`, and `bcrypt_pbkdf` gems from dependencies
- Resolved by Bogdan Denkovych
@bdenkovych, please can you answer the question: Should this have a feature flag? to help with code review for the Access group.This nudge was added by this triage-ops policy.
added 784 commits
-
2a143729...4281daf6 - 783 commits from branch
master
- 91a7c32b - Remove `net-ssh`, `ed25519`, and `bcrypt_pbkdf` gems from dependencies
-
2a143729...4281daf6 - 783 commits from branch
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
- Resolved by Bogdan Denkovych
@dblessing Could you please review this MR?
requested review from @dblessing
Setting label(s) ~"Category:Authentication and Authorization" devopsmanage sectiondev based on ~"group::authentication and authorization".
added devopsmanage sectiondev + 1 deleted label
removed review request for @dblessing
requested review from @minac
removed review request for @minac
@minac
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
requested review from @ifarkas
- Resolved by Bogdan Denkovych
- Resolved by Imre Farkas
enabled an automatic merge when the pipeline for 2a494de0 succeeds
mentioned in commit ccdef44c
added workflowstaging-canary label
added workflowstaging label and removed workflowstaging-canary label