Skip to content
Snippets Groups Projects

Remove `net-ssh`, `ed25519`, and `bcrypt_pbkdf` gems from dependencies

Merged Bogdan Denkovych requested to merge remove-net-ssh-gem-from-dependencies into master

What does this MR do and why?

Follow up !77424 (comment 812526274)

In !77424 (merged) we started using ssh_data gem instead of net-ssh and sshkey where possible to facilitate implementation of #213259 (closed).

This MR eliminates the last usage of net-ssh from the codebase and removes net-ssh and its sub dependencies - ed25519 and bcrypt_pbkdf.

Fewer dependencies facilitate development and maintenance, especially during upgrading libraries/gems.

Changelog: other

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

bin/rspec spec/validators/x509_certificate_credentials_validator_spec.rb

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Bogdan Denkovych

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Bogdan Denkovych changed the description

    changed the description

  • removed sectiondev label

  • Bogdan Denkovych
  • Bogdan Denkovych changed the description

    changed the description

  • Bogdan Denkovych changed the description

    changed the description

  • Bogdan Denkovych mentioned in merge request !77424 (merged)

    mentioned in merge request !77424 (merged)

  • added 1 commit

    • 2a143729 - Remove `net-ssh`, `ed25519`, and `bcrypt_pbkdf` gems from dependencies

    Compare with previous version

  • Bogdan Denkovych changed the description

    changed the description

  • Setting label ~"group::authentication and authorization" based on @bdenkovych's group.

  • Bogdan Denkovych deleted the use-ssh_data-gem branch. This merge request now targets the master branch

    deleted the use-ssh_data-gem branch. This merge request now targets the master branch

  • Bogdan Denkovych added 784 commits

    added 784 commits

    • 2a143729...4281daf6 - 783 commits from branch master
    • 91a7c32b - Remove `net-ssh`, `ed25519`, and `bcrypt_pbkdf` gems from dependencies

    Compare with previous version

  • Bogdan Denkovych marked this merge request as ready

    marked this merge request as ready

  • Bogdan Denkovych marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

    marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

  • Bogdan Denkovych requested review from @dblessing

    requested review from @dblessing

  • Setting label(s) ~"Category:Authentication and Authorization" devopsmanage sectiondev based on ~"group::authentication and authorization".

  • added devopsmanage sectiondev + 1 deleted label

  • Bogdan Denkovych removed review request for @dblessing

    removed review request for @dblessing

  • Bogdan Denkovych requested review from @minac

    requested review from @minac

  • Mehmet Emin INAC approved this merge request

    approved this merge request

  • Mehmet Emin INAC removed review request for @minac

    removed review request for @minac

  • :wave: @minac, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.

    For more info, please refer to the following links:

  • Bogdan Denkovych requested review from @ifarkas

    requested review from @ifarkas

  • Drew Blessing
  • Drew Blessing approved this merge request

    approved this merge request

  • Imre Farkas
  • Imre Farkas approved this merge request

    approved this merge request

  • Imre Farkas resolved all threads

    resolved all threads

  • Imre Farkas enabled an automatic merge when the pipeline for 2a494de0 succeeds

    enabled an automatic merge when the pipeline for 2a494de0 succeeds

  • merged

  • Imre Farkas mentioned in commit ccdef44c

    mentioned in commit ccdef44c

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading