Remove ci_store_trace_outside_transaction feature flag

What does this MR do and why?

We changed carrierwave to upload the files to object store outside of the database transaction because it was holding the transactions open for too long. This has been enabled for a few releases and I think it's safe to remove the feature flag.

Related to #336280 (closed)

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

• I have evaluated the MR acceptance checklist for this MR.