Skip to content
Snippets Groups Projects

Geo: Fix undefined separate_verification_state_table?

Merged Michael Kozono requested to merge mk/fix-separate-verification-state-table-method into master
2 unresolved threads

What does this MR do and why?

Describe in detail what your merge request does and why.

Fixes an undefined method (separate_verification_state_table?) error during VerificationTimeoutWorker jobs.

Fixes #350359 (closed)

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Be running Geo
  2. In the secondary site, gdk tail | grep "VerificationTimeoutWorker" see that VerificationTimeoutWorker runs for each replicator every minute, and doesn't error
  3. Or run e.g. bin/rails runner "::Geo::VerificationTimeoutWorker.perform_async('snippet_repository')" and see that it doesn't error

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Author Maintainer

    @vsizov Would you please review?

  • Michael Kozono requested review from @vsizov

    requested review from @vsizov

  • Michael Kozono mentioned in merge request !77257 (merged)

    mentioned in merge request !77257 (merged)

  • Valery Sizov approved this merge request

    approved this merge request

  • Valery Sizov removed review request for @vsizov

    removed review request for @vsizov

  • :wave: @vsizov, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.

    For more info, please refer to the following links:

  • Author Maintainer

    Thanks @vsizov!

    @mikolaj_wawrzyniak Would you please review as maintainer?

  • requested review from @mikolaj_wawrzyniak

  • Author Maintainer

    @Andysoiron Would you please review as maintainer? Mikołaj is OOO.

  • Michael Kozono requested review from @Andysoiron and removed review request for @mikolaj_wawrzyniak

    requested review from @Andysoiron and removed review request for @mikolaj_wawrzyniak

  • Author Maintainer

    Adding Pick into 14.7 since the bug was introduced in !77257 (merged) which was merged in 14.7.

  • Michael Kozono changed milestone to %14.8

    changed milestone to %14.8

  • mentioned in issue #349281 (closed)

  • Andy Schoenen approved this merge request

    approved this merge request

  • Thank you @mkozono! Looks good, merging :rocket:

  • Andy Schoenen resolved all threads

    resolved all threads

  • Andy Schoenen enabled an automatic merge when the pipeline for 02e5061b succeeds

    enabled an automatic merge when the pipeline for 02e5061b succeeds

  • merged

  • Andy Schoenen mentioned in commit 9b34f6cb

    mentioned in commit 9b34f6cb

  • added workflowcanary label and removed workflowstaging label

  • Valery Sizov mentioned in merge request !78596 (merged)

    mentioned in merge request !78596 (merged)

  • added workflowproduction label and removed workflowcanary label

  • mentioned in merge request !79966 (merged)

  • Catalin Irimie changed milestone to %14.7

    changed milestone to %14.7

  • Please register or sign in to reply
    Loading