Geo: Fix undefined separate_verification_state_table?
What does this MR do and why?
Describe in detail what your merge request does and why.
Fixes an undefined method (separate_verification_state_table?
) error during VerificationTimeoutWorker
jobs.
Fixes #350359 (closed)
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
- Be running Geo
- In the secondary site,
gdk tail | grep "VerificationTimeoutWorker"
see thatVerificationTimeoutWorker
runs for each replicator every minute, and doesn't error - Or run e.g.
bin/rails runner "::Geo::VerificationTimeoutWorker.perform_async('snippet_repository')"
and see that it doesn't error
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %14.7
assigned to @mkozono
- A deleted user
added backend label
1 Warning This merge request is quite big (612 lines changed), please consider splitting it into multiple merge requests. Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Luis Mejia ( @lmejia2
) (UTC-6, 2 hours ahead of@mkozono
)Andy Soiron ( @Andysoiron
) (UTC+1, 9 hours ahead of@mkozono
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Andy Schoenen
@vsizov Would you please review?
requested review from @vsizov
mentioned in merge request !77257 (merged)
removed review request for @vsizov
@vsizov
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
Thanks @vsizov!
@mikolaj_wawrzyniak Would you please review as maintainer?
requested review from @mikolaj_wawrzyniak
requested review from @Andysoiron and removed review request for @mikolaj_wawrzyniak
Adding Pick into 14.7 since the bug was introduced in !77257 (merged) which was merged in 14.7.
changed milestone to %14.8
added Pick into 14.7 label
mentioned in issue #349281 (closed)
Thank you @mkozono! Looks good, merging
enabled an automatic merge when the pipeline for 02e5061b succeeds
mentioned in commit 9b34f6cb
added workflowstaging-canary label
added workflowstaging label and removed workflowstaging-canary label
added workflowcanary label and removed workflowstaging label
mentioned in merge request !78596 (merged)
@mkozono I've added the happy-path spec for
Geo::VerificationTimeoutWorker
directly here !78596 (merged) as an addition to this MR. WDYT?@vsizov That sounds great, thank you!
added workflowproduction label and removed workflowcanary label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!562 (merged)
@mkozono This merge request could not automatically be picked into
14-7-stable-ee
for14.7.2-ee
and will need manual intervention.Create a new merge request targeting the
14-7-stable-ee-patch-2
branch in order to have this MR included in !79966 (merged).Please follow the Process for Developers.
Looks like this actually made %14.7 in the first
v14.7.0-ee
package so a backport isn't needed at all:╰─>$ git tag --contains 9b34f6cbffbce6f2cf82f397a19a12ee5444787b v14.7.0-ee v14.7.0-rc42-ee
removed Pick into 14.7 label
mentioned in merge request !79966 (merged)
changed milestone to %14.7