Remove opt_in_sidekiq_status feature flag
This feature flag was added in #343964 (closed).
It controls behaviour of the SidekiqStatus middleware, which is used for tracking the status of Sidekiq jobs:
- When disabled, all jobs would be tracked.
- When enabled, only jobs that opt-in to tracking would be tracked.
The reason we want option 2 is that we run a lot of SET commands on the redis-sidekiq instance that are storing data that's never read.
This has been in place in production for a few days now with no issues - there isn't a huge performance improvement, but it's also got no apparent downside.
For #343964 (closed).
Edited by Sean McGivern