Skip to content

Remove extraneous `+` from expanded GFM url references

Brett Walker requested to merge 348748-expanding-gfm-references-into-titles-with-the-character-produces-invalid-urls into master

What does this MR do and why?

!75719 (merged) added the ability to add the title for urls, like https://gitlab.com/gitlab-org/gitlab/-/merge_requests/75719+

The + was not being stripped off the actual href, so the link was invalid. This fixes that.

How to set up and validate locally

Add comment with the content

https://gitlab.com/gitlab-org/gitlab/-/merge_requests/75719

(or something local), and clicking on the link should take you to the proper page, the merge request in the above example.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #348748 (closed)

Edited by Brett Walker

Merge request reports