Improve visibility radio option text on new project page
What does this MR do and why?
This MR makes the visibility radio option text translatable on the new project page. This resolves #343257 (closed) which was a follow-up from !72318 (merged)
Screenshots or screen recordings
No visual changes
before | after |
---|---|
![]() |
![]() |
How to set up and validate locally
- Visit the new project page and test the MR. http://127.0.0.1:3000/projects/new
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #343257 (closed) Closes #343257 (closed)
Merge request reports
Activity
changed milestone to %14.7
added devopsfoundations frontend sectiondev typemaintenance + 1 deleted label
assigned to @cngo
1 Warning You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the ~"type::tooling", ~"tooling::pipelines", ~"tooling::workflow", documentation, QA labels.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Miranda Fluharty ( @mfluharty
) (UTC-7, 7 hours behind@cngo
)Natalia Tepluhina ( @ntepluhina
) (UTC+1, 1 hour ahead of@cngo
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits c177c7ff and bce954ea
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.66 MB 3.66 MB - 0.0 % mainChunk 2.28 MB 2.28 MB - 0.0 %
Note: We do not have exact data for c177c7ff. So we have used data from: bddef177.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Danger- Resolved by Nicolò Maria Mezzopera
@tristan.read Can you review my MR please?
requested review from @tristan.read
requested review from @nmezzopera and removed review request for @tristan.read
@tristan.read
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
enabled an automatic merge when the pipeline for 56fbd010 succeeds
Allure report
allure-report-publisher
generated test report for bce954ea!review-qa-reliable:
test report
review-qa-smoke: test reportadded 274 commits
-
86e7c3c7...ff53a49b - 273 commits from branch
master
- bce954ea - Improve visibility radio option text on new project page
-
86e7c3c7...ff53a49b - 273 commits from branch
@nmezzopera The pipeline wouldn't execute all tests for some reason so I've rebased and all is green. Can you hit the merge button please?
enabled an automatic merge when the pipeline for c85c701f succeeds
mentioned in commit ca2c9caa
added workflowstaging-canary label
added workflowstaging label and removed workflowstaging-canary label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
mentioned in issue #343257 (closed)
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!562 (merged)
added devopsdata stores grouptenant scale sectioncore platform labels and removed devopsfoundations sectiondev + 1 deleted label