Mark `Projects::OverwriteProjectService#destroy_old_project` as doing cross-DB

What does this MR do and why?

It appears that #destroy_old_project does Project.transaction which makes Projects::DestroyService#delete_ci_records! to run in a transaction.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

• I have evaluated the MR acceptance checklist for this MR.