test: Install Gitaly incrementally (again)

Toon Claesrequested to merge
toon-gitaly-incrementally-again into master

What does this MR do and why?

This is the second attempt to introduce the changes from !76558 (merged).

It has some additional commits:

  • 7289fa07 workhorse: Use scripts/gitaly-test-spawn in test
  • 200ee426 test: Remove GitalySetup#wait method
  • 4d8f588e test: Raise exception when Gitaly build fails
  • d91184c2 test: Only set HOME when spawning Gitaly

How to set up and validate locally

Use a GDK that depends on Go being installed by asdf and do not have installed in any other way.

  1. Run rm -rf tmp/tests/gitaly
  2. Run any test, for example: bin/rake frontend:fixtures

Also test whether workhorse tests succeed:

  1. cd workhorse
  2. GITALY_ADDRESS="tcp://127.0.0.1:8075" make test

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Toon Claes

Merge request reports