Add canary specific storage test
Description of the test
Adds a new :smoke
test based on an existing :smoke
test that targets specific canary gitaly storage servers.
TODO: setup test case and add link to testcases project
Closes #350049 (closed)
Checklist
-
Confirm the test has a testcase:
tag linking to an existing test case in the test case project. -
Note if the test is intended to run in specific scenarios. If a scenario is new, add a link to the MR that adds the new scenario. -
Follow the end-to-end tests style guide and best practices. -
Use the appropriate RSpec metadata tag(s). -
Ensure that a created resource is removed after test execution. A Group
resource can be shared between multiple tests. Do not remove it unless it has a unique path. Note that we have a cleanup job that periodically removes groups undergitlab-qa-sandbox-group
. -
Ensure that no transient bugs are hidden accidentally due to the usage of waits
andreloads
. -
Verify the tags to ensure it runs on the desired test environments. -
If this MR has a dependency on another MR, such as a GitLab QA MR, specify the order in which the MRs should be merged. -
(If applicable) Create a follow-up issue to document the special setup necessary to run the test: ISSUE_LINK -
If the test requires an admin's personal access token, ensure that the test passes on your local environment with and without the GITLAB_QA_ADMIN_ACCESS_TOKEN
provided.
Merge request reports
Activity
changed milestone to %14.7
assigned to @zeffmorgan
added typefeature label and removed typemaintenance label
1 Warning featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer QA Tomislav Nikić ( @tomi
) (UTC+1, 6 hours ahead of@zeffmorgan
)Dan Davison ( @ddavison
) (UTC-5, same timezone as@zeffmorgan
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangermentioned in issue #341427 (closed)
Allure report
allure-report-publisher
generated test report for 067de352!review-qa-reliable:
test report
review-qa-smoke: test report
package-and-qa: test report
review-qa-all: test reportchanged milestone to %14.8
added missed:14.7 label
added 2246 commits
-
5156699e...46099516 - 2245 commits from branch
master
- fbc027f9 - Add canary specific storage test
-
5156699e...46099516 - 2245 commits from branch
added 1 commit
- cdad11f2 - Explicitly declare target storage and limit domains
marked the checklist item Confirm the test has a
testcase:
tag linking to an existing test case in the test case project. as completedmarked the checklist item Follow the end-to-end tests style guide and best practices. as completed
marked the checklist item Use the appropriate RSpec metadata tag(s). as completed
marked the checklist item Ensure that no transient bugs are hidden accidentally due to the usage of
waits
andreloads
. as completedmarked the checklist item (If applicable) Create a follow-up issue to document the special setup necessary to run the test: ISSUE_LINK as completed
requested review from @willmeek
- Resolved by Zeff Morgan
@willmeek your name came up in the roulette. Once this passes without related issues, would you mind giving a first review?
- Resolved by Zeff Morgan
added 1011 commits
-
52f6ac76...5c04cf4d - 1007 commits from branch
master
- 7bbb1305 - Add canary specific storage test
- ab220738 - Explicitly declare target storage and limit domains
- 10c68f6d - Fix erroneous comma
- c96ec9e4 - Fix rubocop errors
Toggle commit list-
52f6ac76...5c04cf4d - 1007 commits from branch
added 996 commits
-
c96ec9e4...87e16374 - 992 commits from branch
master
- 6e0c3386 - Add canary specific storage test
- d6c1dd2c - Explicitly declare target storage and limit domains
- 9a064b83 - Fix erroneous comma
- 067de352 - Fix rubocop errors
Toggle commit list-
c96ec9e4...87e16374 - 992 commits from branch
The
package-and-qa
job from pipeline https://gitlab.com/gitlab-org/gitlab/-/pipelines/465610310 triggered https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/465612220 downstream.The
gitlab-qa
downstream pipeline passed. .The
package-and-qa
job from pipeline https://gitlab.com/gitlab-org/gitlab/-/pipelines/466008996 triggered https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/466024994 downstream.The
gitlab-qa
downstream pipeline passed. .
Thanks @zeffmorgan nice work!
- Resolved by Zeff Morgan
@zeffmorgan I added one minor suggestion where I myself encountered such an issue with retry and static project name.
enabled an automatic merge when the pipeline for 3903facd succeeds
mentioned in commit 74978657
added workflowstaging-canary label
added workflowstaging label and removed workflowstaging-canary label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label