Skip to content

Update approval settings to show a toast on success

Jiaan Louw requested to merge 337525-update-approval-settings-to-use-success-toast into master

What does this MR do and why?

This MR updates the shared merge request approval settings to display a GlToast instead of a GlAlert to resolve #337525 (closed).

This changes the group and project-level approval settings. It does not affect the admin level approval settings.

Screenshots or screen recordings

Project approval settings

Before After
Screen_Recording_2022-01-11_at_17.04.53 Screen_Recording_2022-01-11_at_16.56.35

Group approval settings

Before After
Screen_Recording_2022-01-11_at_17.03.18 Screen_Recording_2022-01-11_at_16.54.28

How to set up and validate locally

To test the approval settings:

  1. You need a GitLab Ultimate license.
  2. Checkout the feature branch.
  3. View the project-level Approval settings under Merge request approvals: [GDK_HOST]/gitlab-org/gitlab-shell/edit
  4. Enable or disabled some of the settings and click save changes.
  5. Verify that the toast message is shown and no alert is rendered.
  6. Test that the setting are enforced on one of the project's merge requests.
  7. Repeat steps 4, 5 and 6 for group-level Approval settings: [GDK_HOST]/groups/gitlab-org/-/edit

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #337525 (closed)

Edited by Jiaan Louw

Merge request reports