Disable copy-code button for mermaid diagrams
Related issues - #349497 (closed), #349892 (closed)
What does this MR do and why?
It removes the copy-code
button for mermaid diagrams, fixing #349497 (closed), and potentially #349892 (closed) also.
It was added in !75433 (merged), and intended for only code blocks and not the mermaid diagrams I suppose.
Screenshots or screen recordings
- Copy clipboard button
before | after (renders only for code block) |
---|---|
![]() |
![]() |
- Mermaid diagram rendering issue
Intermittent issue (both diagrams are not rendered) | Intermittent issue (one diagram is not rendered) | After fix |
---|---|---|
![]() |
![]() |
![]() |
How to set up and validate locally
- Create a new issue / MR with the following comment
- Enclose it with
mermaid ...
sequenceDiagram
User->>GitLab: GET /project/-/archive/master.zip
GitLab->>User: 302 Found
Note over User,GitLab: Location: https://cdn.com/project/-/archive/master.zip?token=secure-user-token
User->>CDN: GET /project/-/archive/master.zip?token=secure-user-token
alt object not in cache
CDN->>GitLab: GET /project/-/archive/master.zip
Note over CDN,GitLab: X-Gitlab-External-Storage-Token: secure-cdn-token<br/>X-Gitlab-Static-Object-Token: secure-user-token
GitLab->>CDN: 200 OK
CDN->>User: master.zip
else object in cache
CDN->>GitLab: GET /project/-/archive/master.zip
Note over CDN,GitLab: X-Gitlab-External-Storage-Token: secure-cdn-token<br/>X-Gitlab-Static-Object-Token: secure-user-token<br/>If-None-Match: etag-value
GitLab->>CDN: 304 Not Modified
CDN->>User: master.zip
end
graph LR; A-->C;
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
assigned to @djadmin
- A deleted user
added frontend label
1 Warning You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the ~"type::tooling", ~"tooling::pipelines", ~"tooling::workflow", documentation, QA labels.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Robert Hunt ( @rob.hunt
) (UTC+0, 5.5 hours behind@djadmin
)Nicolò Maria Mezzopera ( @nmezzopera
) (UTC+1, 4.5 hours behind@djadmin
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangerremoved frontend label
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
changed milestone to %14.7
added devopsplan frontend groupproject management sectiondev typebug labels
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 48d4d05d and ca5833e1
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.65 MB 3.65 MB - -0.0 % mainChunk 2.27 MB 2.27 MB - -0.0 %
Note: We do not have exact data for 48d4d05d. So we have used data from: 55d94517.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangeradded 1 commit
- ca5833e1 - Disable copy-code button for mermaid diagrams
requested review from @iamphill
@iamphill would you please review the changes?
Allure report
allure-report-publisher
generated test report for ca5833e1!review-qa-smoke:
test report
review-qa-reliable: test report@iamphill
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
enabled an automatic merge when the pipeline for 79e2a385 succeeds
mentioned in commit 7a3a4c0b
mentioned in issue #349497 (closed)
mentioned in issue #349892 (closed)
added workflowstaging-canary label
added workflowstaging label and removed workflowstaging-canary label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
mentioned in merge request !78031 (merged)
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!562 (merged)