Add index for selecting active agent tokens

assigned to @tigerwnz

mentioned in merge request !77735 (merged)

added database databasereview pending labels

changed the description

removed database databasereview pending labels

changed milestone to %14.7

added database databasereview pending groupconfigure [DEPRECATED] labels

added featureenhancement label

added typefeature label

	1 Warning
	You've made some app changes, but didn't add any tests. That's OK as long as you're refactoring existing code, but please consider adding any of the ~"type::tooling", ~"tooling::pipelines", ~"tooling::workflow", documentation, QA labels.

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
database	Mehmet Emin Inac (`@minac`) (UTC+3, 8 hours behind `@tigerwnz`)	Andreas Brandl (`@abrandl`) (UTC+1, 10 hours behind `@tigerwnz`)
~migration	No reviewer available	No maintainer available

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

added typemaintenance label and removed featureenhancement typefeature labels

@minac can you please review?

requested review from @minac

changed the description

mentioned in issue #348386 (closed)

approved this merge request

added databasereviewed label and removed databasereview pending label

requested review from @mayra-cabrera and removed review request for @minac

@minac, thanks for approving this merge request.

This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.

For more info, please refer to the following links:

changed the description

Setting label(s) ~"devops::configure" sectionops based on ~"group::configure".

added devopsconfigure [DEPRECATED] sectionops labels

Database migrations

Migrations included in this change have been executed on gitlab.com data for testing purposes. For details, please see the migration testing pipeline (limited access).

Migration	Type	Total runtime	Result	DB size change
20220111023852 - IndexClusterAgentTokensOnStatus	Post deploy	1.8 s		+104.00 KiB

Runtime Histogram for all migrations

Query Runtime	Count
0 seconds - 0.01 seconds	0
0.01 seconds - 0.1 seconds	3
0.1 seconds - 1 second	0
1 second - 5 minutes	0
5 minutes +	0

Migration: 20220111023852 - IndexClusterAgentTokensOnStatus

Type: Post deploy
Duration: 1.8 s
Database size change: +104.00 KiB

Query

Calls

Total Time

Max Time

Mean Time

Rows

CREATE INDEX CONCURRENTLY "index_cluster_agent_tokens_on_agent_id_status_last_used_at" ON "cluster_agent_tokens" (agent_id, status, last_used_at DESC NULLS LAST) /*application:test,db_config_name:main*/

1

11.2 ms

0

SELECT "feature_gates".*
  FROM "feature_gates"
  WHERE "feature_gates"."feature_key" = $1 /*application:test,db_config_name:main*/

1

1.7 ms

1

SELECT "postgres_async_indexes".*
  FROM "postgres_async_indexes"
  WHERE "postgres_async_indexes"."name" = $1
  LIMIT $2 /*application:test,db_config_name:main*/

1

0.1 ms

0

Histogram for IndexClusterAgentTokensOnStatus