Change shared addon component tests to accommodate tests for CI minutes
What does this MR do and why?
This is the first step towards moving addon related data to GraphQL and comprises of changing the current tests for BuyAddonsApp
to accommodate new tests for minutes.
Currently the tests for BuyAddonsApp
are around Storage only.
With this MR:
- We remove the default response (
mockCiMinutesPlans
) forplansQueryMock
increateMockApolloProvider
. This lets us be explicit about what mock data is being passed when invokingcreateMockApolloProvider
which will be useful when we add tests for CI Minutes. - We make
createComponent
accept an additional argument calledpropsData
through which we can pass props for both Storage and CI Minutes when creating respective components
Screenshots or screen recordings
The changes in this MR are purely test related and the implementation is unchanged.
How to set up and validate locally
Test suite that's affected by this change is ee/spec/frontend/subscriptions/buy_addons_shared/app_spec.js
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #346620 (closed)
Edited by Vamsi Vempati