Log QA resource reuse
What does this MR do and why?
Changes the debug log message shown when a resource is fabricated.
- "Built" as previously, when a resource is created.
- "Retrieved" when an existing resource is fetched.
- "Retrieved for reuse" when an existing resource is fetched as a reusable resource.
Adds a ReusableGroup
class so that ResuableProject
is truly reusable (otherwise ResuableProject
would create a new group in a different project each time).
Part of https://gitlab.com/gitlab-org/quality/team-tasks/-/issues/1032
Examples
Previously, the debug log for fabricating a resource always said Built
, like this:
==> Built a QA::Resource::Project with full_path 'gitlab-qa-sandbox-group/contribution_analytics-a630bee295505362/contribution_analytics-d94f429a07bfa22a' via api in 0.607407829 seconds
Now it still says Built
when a new resource is created, but if an existing resource is fetched (instead of creating a new one), it says something like:
==> Retrieved a QA::Resource::Group with full_path 'gitlab-qa-sandbox-group/qa-test-2022-01-10-23-52-28-6e54ea33b183dbe5' via api in 1.244220592 seconds
And if it's a reusable resource:
==> Retrieved for reuse a QA::Resource::ReusableGroup with full_path 'gitlab-qa-sandbox-group/reusable_group' via api in 0.804077896 seconds
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %14.7
added QA Quality typemaintenance labels
assigned to @mlapierre
1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer QA Sofia Vistas ( @svistas
) (UTC+2, 9 hours behind@mlapierre
)Dan Davison ( @ddavison
) (UTC-5, 16 hours behind@mlapierre
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Andrejs Cunskis
Allure report
allure-report-publisher
generated test report for 1db048cb!review-qa-smoke:
test report
review-qa-reliable: test report
review-qa-all: test report
package-and-qa: test report
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
- Resolved by Mark Lapierre
@grantyoung Could you please review this change?
requested review from @grantyoung
@grantyoung
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.
For more info, please refer to the following links:
- Resolved by Andrejs Cunskis
@acunskis Could you please review this change as maintainer?
requested review from @acunskis
- Resolved by Andrejs Cunskis
- Resolved by Mark Lapierre
added 622 commits
-
a99c7b45...dfdb363a - 620 commits from branch
master
- a3634ef4 - Log QA resource reuse
- 1db048cb - Pass api client to nested resource
-
a99c7b45...dfdb363a - 620 commits from branch
The
qa-test
job from pipeline https://gitlab.com/gitlab-org/build/omnibus-gitlab-mirror/-/pipelines/446912309 triggered https://gitlab.com/gitlab-org/gitlab-qa-mirror/-/pipelines/446927519 downstream.The
gitlab-qa
downstream pipeline failed! .
mentioned in commit 9f083200
added workflowstaging-canary label
added workflowstaging label and removed workflowstaging-canary label
added workflowcanary label and removed workflowstaging label
added workflowproduction label and removed workflowcanary label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in issue gitlab-org/quality/pipeline-triage#139 (closed)
mentioned in issue gitlab-org/quality/pipeline-triage#158 (closed)
mentioned in issue gitlab-org/quality/pipeline-triage#169 (closed)
mentioned in issue gitlab-org/quality/pipeline-triage#170 (closed)
mentioned in issue gitlab-org/quality/pipeline-triage#172 (closed)
mentioned in issue gitlab-org/quality/pipeline-triage#177 (closed)
mentioned in issue gitlab-org/quality/pipeline-triage#187 (closed)
mentioned in issue gitlab-org/quality/pipeline-triage#189 (closed)
mentioned in issue gitlab-org/quality/pipeline-triage#190 (closed)
mentioned in issue gitlab-org/quality/pipeline-triage#191 (closed)
mentioned in issue gitlab-org/quality/pipeline-triage#192 (closed)
mentioned in issue gitlab-org/quality/pipeline-triage#193 (closed)
mentioned in issue gitlab-org/quality/pipeline-triage#194 (closed)
mentioned in issue gitlab-org/quality/pipeline-triage#196 (closed)
mentioned in issue gitlab-org/quality/pipeline-triage#197 (closed)
mentioned in issue gitlab-org/quality/pipeline-triage#198 (closed)
mentioned in issue gitlab-org/quality/pipeline-triage#199 (closed)
mentioned in issue gitlab-org/quality/pipeline-triage#200 (closed)
mentioned in issue gitlab-org/quality/pipeline-triage#201 (closed)
mentioned in issue gitlab-org/quality/pipeline-triage#202 (closed)
mentioned in issue gitlab-org/quality/pipeline-triage#203 (closed)
mentioned in issue gitlab-org/quality/pipeline-triage#206 (closed)
mentioned in issue gitlab-org/quality/pipeline-triage#207 (closed)
mentioned in issue gitlab-org/quality/pipeline-triage#209 (closed)