Add runner token expiration interval settings

@KyleFromKitware

Thank you for your contribution to GitLab. We believe that everyone can contribute and contributions like yours are what make GitLab great!

Our Merge Request Coaches will ensure your contribution is reviewed in a timely manner*.
If you haven't, please set up a DANGER_GITLAB_API_TOKEN.
You can comment @gitlab-bot label ~"group::" to add a group label.
When you feel your MR (merge request) is ready for a review, just ask @gitlab-bot request_review and someone will take a look.
If you are stuck, feel free to ask @gitlab-bot help or ping a Merge Request Coach.
Read more on how to get help.

This message was generated automatically. You're welcome to improve it.

added Community contribution label

assigned to @KyleFromKitware

/cc @pedropombeiro

mentioned in merge request !71607 (closed)

added 4 commits

d82f268d - ApplicationSetting: Add runner_token_expiration_interval field
1666d515 - Concerns: Add RunnerTokenExpirationInterval concern
a7163a62 - Group: Add runner token expiration interval settings
3ad17d66 - Project: Add runner token expiration interval settings

Compare with previous version

changed title from ApplicationSetting: Add runner{--}token{--}expiration_interval field to Add runner token expiration interval settings

mentioned in issue gitlab-org/quality/triage-reports#5997 (closed)

mentioned in merge request !77899 (merged)

added 232 commits

3ad17d66...d1efd8d3 - 228 commits from branch gitlab-org:master
5293781f - ApplicationSetting: Add runner_token_expiration_interval field
85ed4c32 - Concerns: Add RunnerTokenExpirationInterval concern
816103cc - Group: Add runner token expiration interval settings
f3264a84 - Project: Add runner token expiration interval settings

Compare with previous version

mentioned in issue gitlab-org/quality/triage-reports#5999 (closed)

requested review from @pedropombeiro

changed milestone to %14.6

added ~20757940 Technical Writing UI text UX [Deprecated] Category:Runner backend customer database databaseapproved devopsverify docsfeature documentation frontend grouprunner missed:14.4 missed:14.5 pipeline:run-as-if-foss sectionops security-awardsnomination twtriaged typefeature labels

Thanks for helping us improve the UX of GitLab, your contribution is appreciated! We have pinged UX team members, stay tuned for their feedback.

@pbair this MR is a broken-down version of the initial !71607 (closed) which you approved (the remaining MRs in the chain are !77884 (merged) and !77899 (merged)). Would you mind adding your approval here?

requested review from @pbair

changed milestone to %14.7

removed docsfeature label

removed Technical Writing label

removed twtriaged label

removed UX label

removed missed:14.4 label

removed UI text label

removed frontend label

removed documentation label

removed missed:14.5 label

	1 Warning
	This merge request is quite big (591 lines changed), please consider splitting it into multiple merge requests.

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
backend	Marc Shaw (`@marc_shaw`) (UTC+1)	Kerri Miller (`@kerrizor`) (UTC-8)
database	Nikola Milojevic (`@nmilojevic1`) (UTC+1)	Adam Hegyi (`@ahegyi`) (UTC+1)
~migration	No reviewer available	No maintainer available

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

resolved all threads

added 2 commits

727ef130 - Group: Add runner token expiration interval settings
4a4c81dc - Project: Add runner token expiration interval settings

Compare with previous version

approved this merge request

@KyleFromKitware All the database changes look good to me from being carried over from the previous MR. Thanks!

removed review request for @pbair

@pbair, thanks for approving this merge request.

This is the first time the merge request is approved. To ensure full test coverage, please start a new pipeline before merging.

For more info, please refer to the following links:

added 1 commit

de936fc3 - Project: Add runner token expiration interval settings

Compare with previous version

added 2 commits

3dde1f7d - Group: Add runner token expiration interval settings
087f543d - Project: Add runner token expiration interval settings

Compare with previous version

added 1 commit

d3c3f463 - Project: Add runner token expiration interval settings

Compare with previous version

added 735 commits

d3c3f463...da120cce - 731 commits from branch gitlab-org:master
f24ec2d7 - ApplicationSetting: Add runner_token_expiration_interval field
a592669f - Concerns: Add RunnerTokenExpirationInterval concern
1d58ea7b - Group: Add runner token expiration interval settings
7a367f22 - Project: Add runner token expiration interval settings

Compare with previous version

added 251 commits

7a367f22...f1083234 - 247 commits from branch gitlab-org:master
8b4a61cc - ApplicationSetting: Add runner_token_expiration_interval field
b00e2c4c - Concerns: Add RunnerTokenExpirationInterval concern
ff800f47 - Group: Add runner token expiration interval settings
2c67a63e - Project: Add runner token expiration interval settings

Compare with previous version

What in the world is going on with CI? It's red across the board. @pedropombeiro

added 8 commits

2c67a63e...d17cd9f9 - 4 commits from branch gitlab-org:master
1ef9bac8 - ApplicationSetting: Add runner_token_expiration_interval field
8d34dfc5 - Concerns: Add RunnerTokenExpirationInterval concern
7054203e - Group: Add runner token expiration interval settings
9ba60554 - Project: Add runner token expiration interval settings

Compare with previous version

changed milestone to %14.8

approved this merge request

LGTM! Thanks @KyleFromKitware for all the effort you put into this and the follow-up MRs! I've started a new pipeline, hoping it will be rebased automatically onto a green commit. If not, you'll need to rebase the branch, as I believe the problem has been fixed.

Hey @mkaeppler , mind doing the backend maintainer review?

requested review from @mkaeppler and removed review request for @pedropombeiro

changed the description

removed review request for @mkaeppler

added 104 commits

9ba60554...2ef40a56 - 100 commits from branch gitlab-org:master
3d7c8867 - ApplicationSetting: Add runner_token_expiration_interval field
6008a58d - Concerns: Add RunnerTokenExpirationInterval concern
f259f79f - Group: Add runner token expiration interval settings
cf0f3ddf - Project: Add runner token expiration interval settings

Compare with previous version

added 4 commits

9a2b93a4 - ApplicationSetting: Add runner_token_expiration_interval field
22002809 - Concerns: Add RunnerTokenExpirationInterval concern
69dcbd67 - Group: Add runner token expiration interval settings
8f301cfb - Project: Add runner token expiration interval settings

Compare with previous version

requested review from @mkaeppler

resolved all threads

approved this merge request

enabled an automatic merge when the pipeline for 45458664 succeeds

merged

mentioned in commit 11a340f2

Hi @KyleFromKitware,

We would love to know how you found your code review experience in this merge request! Please leave a or a on this comment to describe your experience.

Once done, please comment @gitlab-bot feedback below and feel free to leave any additional feedback you have in the same comment.

Thanks for your help!

Great job getting this MR merged @KyleFromKitware, it's much easier with smaller MRs! Let's move on to !77899 (merged) which should be pretty quick to get reviewed