Skip to content

Replace window.confirm with GlModal for registration token reset

Jannik Lehmann requested to merge jnnkl-gl-modal-registration-token-reset into master

What does this MR do and why?

This MR solves: #344124 (closed) it replaces the window confirm dialog with a GlModal for the runner registration token.

Screenshots or screen recordings

before after
Screenshot_2022-01-10_at_17.37.15 Screenshot_2022-01-10_at_16.57.42

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. login in as root on you gdk
  2. http://gitlab.localdev:3000/admin/runners
  3. click on register an instance runner
  4. click on reset registration token
  5. see modal in action

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Jannik Lehmann

Merge request reports