Skip to content
Snippets Groups Projects

Add subsidized cost factor for Open Source plan

Merged Fabio Pitino requested to merge add-open-source-cost-factor into master
All threads resolved!

What does this MR do and why?

With the new Open Source plan been added specifically for those namespaces member of the Open Source program we are now able to distinguish open source projects from those in either Free or paid plans.

As we aim to harden CI minutes limits for all public projects we need to first ensure we don't impact public projects that are part of the Open Source program. For this reason, in this MR we are lowering the cost factor to 0.008 for those open source projects, making the Open Source program more appealing for open source projects and ensuring we don't impact them when we are going to raise the cost factor to 1.0 for public projects in upcoming milestones.

Lowering the cost factor means that CI minutes consumption moves at a slower rate (currently 125x slower than on private projects), effectively allowing a namespace to use more CI minutes. The limit cost factor 0.008 is low enough to ensure that a namespace can use 125x more CI minutes than their monthly allowance, but it'a also a non-zero value which means that the consumption is still capped.

Screenshots or screen recordings

These are strongly recommended to assist reviewers and reduce the time to merge your change.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Fabio Pitino

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • requested review from @marcel.amirault

  • Fabio Pitino
  • requested review from @shreyasagarwal

  • A deleted user added documentation label

    added documentation label

  • 1 Message
    :book: This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge.

    Documentation review

    The following files require a review from a technical writer:

    • doc/ci/pipelines/cicd_minutes.md

    The review does not need to block merging this merge request. See the:

    Reviewer roulette

    Changes that require review have been detected!

    Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

    Category Reviewer Maintainer
    backend Drew Blessing (@dblessing) (UTC-6, 6 hours behind @fabiopitino) Vasilii Iakliushin (@vyaklushin) (UTC+1, 1 hour ahead of @fabiopitino)

    To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

    Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

    If needed, you can retry the danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

  • Fabio Pitino marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

    marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

  • Fabio Pitino
  • Marcel Amirault removed review request for @marcel.amirault

    removed review request for @marcel.amirault

  • Fabio Pitino added 1 commit

    added 1 commit

    • 34189eef - Add subsidized cost factor for Open Source plan

    Compare with previous version

  • Fabio Pitino added 1 commit

    added 1 commit

    • d976e210 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Marcel Amirault approved this merge request

    approved this merge request

  • :wave: @marcel.amirault, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.

    For more info, please refer to the following links:

  • Fabio Pitino requested review from @vij and removed review request for @shreyasagarwal

    requested review from @vij and removed review request for @shreyasagarwal

  • Vijay Hawoldar
  • Vijay Hawoldar
  • Vijay Hawoldar
  • Vijay Hawoldar approved this merge request

    approved this merge request

  • @fabiopitino this LGTM! I've left a few non-blocking comments so I'll pass back to you incase you wanted to take a look, but approving anyway!

  • Vijay Hawoldar removed review request for @vij

    removed review request for @vij

  • Fabio Pitino added 1 commit

    added 1 commit

    • d68fd0d2 - Add subsidized cost factor for Open Source plan

    Compare with previous version

  • Fabio Pitino resolved all threads

    resolved all threads

  • Fabio Pitino resolved all threads

    resolved all threads

  • Fabio Pitino requested review from @mbobin

    requested review from @mbobin

  • Marius Bobin
  • Marius Bobin
  • Fabio Pitino added 1 commit

    added 1 commit

    • f71cc952 - Add subsidized cost factor for Open Source plan

    Compare with previous version

  • Fabio Pitino resolved all threads

    resolved all threads

  • mentioned in issue #350325 (closed)

  • Marius Bobin resolved all threads

    resolved all threads

  • Marius Bobin approved this merge request

    approved this merge request

  • Thanks, @fabiopitino! Looks good! :thumbsup:

  • Marius Bobin enabled an automatic merge when the pipeline for 2920f360 succeeds

    enabled an automatic merge when the pipeline for 2920f360 succeeds

  • merged

  • Marius Bobin mentioned in commit 6f09c2fa

    mentioned in commit 6f09c2fa

  • added workflowcanary label and removed workflowstaging label

  • added workflowproduction label and removed workflowcanary label

  • Please register or sign in to reply
    Loading