Use the same email validation for User and Email

Related to #348947 (closed)

Use the same email validation for User and Email. Otherwise, it is possible to successfully save a primary User email, but fail to add it to user.emails because it is invalid for the Email model.

The Email#email validation is now more relaxed, and the same as the User#email validation: it is the Devise email validation, that basically only checks that there is a single @ sign separating local part and domain. The previous stricter Email#email validation was enforcing compliance with RFC3696, but many mail servers allow addresses that are not fully compliant with the RFC. Therefore, the relaxed validation is preferable, to avoid blocking working email addresses.

See also this comment.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

• I have evaluated the MR acceptance checklist for this MR.

assigned to @m_frankiewicz

added backend label

	1 Warning
	This MR changes code in ee/, but its Changelog commit is missing the EE: true trailer. Consider adding it to your Changelog commits.

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
backend	Sean Arnold (@seanarnold) (UTC+13, 12 hours ahead of @m_frankiewicz)	James Fargher (@proglottis) (UTC+13, 12 hours ahead of @m_frankiewicz)
test Quality for spec/features/*	Sanad Liaquat (@sliaquat) (UTC+5, 4 hours ahead of @m_frankiewicz)	Maintainer review is optional for test Quality for spec/features/*

To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

changed milestone to %14.7

added groupoptimize priority2 typebug labels

@dblessing could you review backend please?

requested review from @alberts-gitlab

requested review from @dblessing and removed review request for @alberts-gitlab

Setting label(s) devopsmanage sectiondev based on groupoptimize.

added devopsmanage sectiondev labels

added 1 commit

• 2331c6d8 - Use the same email validation for User and Email

Compare with previous version

changed the description

added 144 commits

• 2331c6d8...752e45af - 143 commits from branch master
• 4696d79d - Use the same email validation for User and Email

Compare with previous version

requested review from @sliaquat

marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

added 105 commits

• 4696d79d...d2c1d017 - 104 commits from branch master
• 45036829 - Use the same email validation for User and Email

Compare with previous version

approved this merge request

@dblessing, thanks for approving this merge request.

This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.

For more info, please refer to the following links:

• rspec minimal jobs
• jest minimal jobs
• merging a merge request.

approved this merge request

resolved all threads

added 58 commits

• 45036829...62403975 - 57 commits from branch master
• c4857524 - Use the same email validation for User and Email

Compare with previous version

requested review from @robotmay_gitlab and removed review request for @dblessing

added 1 commit

• 866a5fa0 - Use the same email validation for User and Email

Compare with previous version

Thanks @m_frankiewicz! Just one question from me, but otherwise this looks good

resolved all threads

approved this merge request

enabled an automatic merge when the pipeline for 1436a1db succeeds

merged

mentioned in commit 64373744

mentioned in merge request !76141 (merged)

added workflowstaging-canary label

added workflowstaging label and removed workflowstaging-canary label

added workflowcanary label and removed workflowstaging label

added workflowproduction label and removed workflowcanary label

mentioned in issue #348947 (closed)

added releasedcandidate label

added releasedpublished label and removed releasedcandidate label

mentioned in merge request kubitus-project/kubitus-installer!562 (merged)

mentioned in issue #350488 (closed)